Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

fix deleting management cluster clean up avi resource error in long latency condition #2329

Merged
merged 1 commit into from
May 23, 2022
Merged

fix deleting management cluster clean up avi resource error in long latency condition #2329

merged 1 commit into from
May 23, 2022

Conversation

XudongLiuHarold
Copy link
Member

@XudongLiuHarold XudongLiuHarold commented May 9, 2022

Signed-off-by: Xudong Liu xudongl@vmware.com

What this PR does / why we need it

Fix when the network condition is poor, clean up avi resources could cause the management cluster deletion failed error.

Which issue(s) this PR fixes

Fixes #2330

Describe testing done for PR

  • launched vSphere testbed, create and delete management cluster several times to verify this change, and test passed.

Release note

deleting management cluster can run successfully even in high latency network env.

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@github-actions
Copy link

github-actions bot commented May 9, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2329/20220509021415/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@XudongLiuHarold XudongLiuHarold added area/cli kind/bug PR/Issue related to a bug area/networking area/lcm Related to Cluster Lifecycle management labels May 9, 2022
@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@alfredthenarwhal
Copy link
Collaborator

@XudongLiuHarold: /test install-vc7
Commit: 669d2f0

Tests failed! Build no: 1947

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2329/20220511194658/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@ZihanJiang96 ZihanJiang96 added the ok-to-merge PRs should be labelled with this before merging label May 12, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2329/20220517210716/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2329/20220517211538/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2329/20220517225830/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@alfredthenarwhal
Copy link
Collaborator

@XudongLiuHarold: /test install-vc7
Commit: 49c51d7

Tests failed! Build no: 2025

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2329/20220519182434/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2329/20220519183514/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@alfredthenarwhal
Copy link
Collaborator

@XudongLiuHarold: /test install-vc7
Commit: 8f3b777

Tests failed! Build no: 2026

@danniel1205
Copy link
Contributor

/lgtm, thanks for the PR. Let's fix the linter.

@danniel1205
Copy link
Contributor

danniel1205 commented May 20, 2022

I see this change has been tested from the bot comment, thanks for having it tested. Could you also help updating the PR description by adding something in Describe testing done for PR ?

…k condition is poor

Signed-off-by: Xudong Liu <xudongl@vmware.com>
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2329/20220520200345/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@3659261). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2329   +/-   ##
=======================================
  Coverage        ?   42.37%           
=======================================
  Files           ?      392           
  Lines           ?    38966           
  Branches        ?        0           
=======================================
  Hits            ?    16510           
  Misses          ?    20911           
  Partials        ?     1545           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3659261...ee47456. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli area/lcm Related to Cluster Lifecycle management area/networking cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When deleting management cluster in a high latency env, clean up avi resources could cause error
8 participants