Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix cliplugins package deletion issue #2400

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix cliplugins package deletion issue #2400

merged 1 commit into from
May 19, 2022

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented May 17, 2022 •
edited
Loading

What this PR does / why we need it

  • Fix cliplugins package deletion issue

Which issue(s) this PR fixes

Fixes #2399

Describe testing done for PR

  • Install framework package
  • Test the framework package to make sure cliplugins package gets deleted successfully

Release note

package-based-lcm: Fix `cliplugins` package deletion issue

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested a review from a team as a code owner May 17, 2022 20:39
prkalle
prkalle approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@anujc25 anujc25 added the ok-to-merge PRs should be labelled with this before merging label May 19, 2022
imikushin
imikushin approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anujc25 anujc25 merged commit 6c125d4 into vmware-tanzu:main May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prkalle prkalle prkalle approved these changes

@imikushin imikushin imikushin approved these changes

Assignees
No one assigned
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uninstallation of cliplugins in framework package fails
4 participants
@anujc25 @imikushin @prkalle @vmwclabot