Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Update SkipCNIBinaries param to CalicoConfig #2416

Merged
merged 1 commit into from
May 26, 2022

Conversation

12345lcr
Copy link
Contributor

@12345lcr 12345lcr commented May 19, 2022

What this PR does / why we need it

  • Update SkipCNIBinaries param to CalicoConfig
  • Add ut for SkipCNIBinaries
  • Remove undefined fields in calico test data files
  • Update crd to sync with api
  • Fix additionalPrinterColumns json path in CRD

Which issue(s) this PR fixes

Fixes #2415

Describe testing done for PR

Ran make test in addons

Release note

package-based-lcm: Update SkipCNIBinaries param to CalicoConfig and fix CRD additionalPrinterColumns

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

Copy link
Contributor

@vijaykatam vijaykatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

Fix lint errors and update release note. Prefix with package-based-lcm.

@12345lcr 12345lcr force-pushed the topic/12345lcr/skipcnibinaries branch from de302f0 to 9d8cfaf Compare May 25, 2022 04:03
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@a83c583). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2416   +/-   ##
=======================================
  Coverage        ?   42.40%           
=======================================
  Files           ?      392           
  Lines           ?    38966           
  Branches        ?        0           
=======================================
  Hits            ?    16525           
  Misses          ?    20902           
  Partials        ?     1539           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83c583...9d8cfaf. Read the comment docs.

@12345lcr
Copy link
Contributor Author

12345lcr commented May 25, 2022

Thanks @vijaykatam ! Lint error fixed and release note updated, please take a look.
I noticed that these related prs are pointing to the branch package-based-lcm instead of main, do I need to create another pr to cherrypick this commit into that branch?

@vijaykatam
Copy link
Contributor

The branch package-based-lcm is targeted for CLI work. This PR should be merged to main. We are already feature gating behind https://github.com/vmware-tanzu/tanzu-framework/blob/main/packages/addons-manager/bundle/config/values.yaml#L15

@vijaykatam vijaykatam added the ok-to-merge PRs should be labelled with this before merging label May 25, 2022
@12345lcr 12345lcr merged commit 59a1bc0 into vmware-tanzu:main May 26, 2022
ankeesler pushed a commit to ankeesler/tanzu-framework that referenced this pull request Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/addons cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SkipCNIBinaries param to CalicoConfig
3 participants