-
Notifications
You must be signed in to change notification settings - Fork 192
Update SkipCNIBinaries param to CalicoConfig #2416
Update SkipCNIBinaries param to CalicoConfig #2416
Conversation
73d5418
to
ff9786c
Compare
ff9786c
to
de302f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me.
Fix lint errors and update release note. Prefix with package-based-lcm
.
de302f0
to
9d8cfaf
Compare
Codecov Report
@@ Coverage Diff @@
## main #2416 +/- ##
=======================================
Coverage ? 42.40%
=======================================
Files ? 392
Lines ? 38966
Branches ? 0
=======================================
Hits ? 16525
Misses ? 20902
Partials ? 1539 Continue to review full report at Codecov.
|
Thanks @vijaykatam ! Lint error fixed and release note updated, please take a look. |
The branch |
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #2415
Describe testing done for PR
Ran make test in addons
Release note
PR Checklist
Additional information
Special notes for your reviewer