Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Bump kapp-controller to version 0.38.4 #2880

Merged

Conversation

shivaani0505
Copy link
Contributor

@shivaani0505 shivaani0505 commented Jul 8, 2022

What this PR does / why we need it

Bump kapp-controller to version 0.38.4

Which issue(s) this PR fixes

Fixes #2879

Describe testing done for PR

Changes in this PR have been run with bom
https://github.com/vmware-tanzu/tanzu-framework/pull/2880#issuecomment-1179547191
All tests are passing with new bom

Release note

Bump kapp-controller to version 0.38.4 

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2880/20220708195254/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2880/20220708200539/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #2880 (9305a72) into main (8711537) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
- Coverage   43.83%   43.81%   -0.03%     
==========================================
  Files         414      414              
  Lines       41295    41295              
==========================================
- Hits        18103    18092      -11     
- Misses      21499    21508       +9     
- Partials     1693     1695       +2     
Impacted Files Coverage Δ
addons/controllers/clusterbootstrap_controller.go 62.93% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8711537...9305a72. Read the comment docs.

@shyaamsn
Copy link
Contributor

shyaamsn commented Jul 9, 2022

//usebom:sandbox/v1.6.0-zshippable/415732029582267120/tkg-compatibility

@shyaamsn shyaamsn requested a review from vijaykatam July 11, 2022 16:52
@vijaykatam
Copy link
Contributor

As @shyaamsn mentioned offline, lets enqueue airgap testing for this change.

@shivaani0505 shivaani0505 added the ok-to-merge PRs should be labelled with this before merging label Jul 11, 2022
@shivaani0505 shivaani0505 merged commit 82ef396 into vmware-tanzu:main Jul 11, 2022
pgandigesang pushed a commit to pgandigesang/tanzu-framework that referenced this pull request Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump kapp controller to 0.38.4 version
4 participants