-
Notifications
You must be signed in to change notification settings - Fork 192
Fix fallback creation with legacy style cluster #2898
Conversation
With bifuraction of cc and non-cc based ytt overlays, non-cc overlays should behave identically regardless of whether the pblcm feature flag is set or not. Fixes: #2830 Signed-off-by: Vui Lam <vui@vmware.com>
Cluster Generation A/B Results: |
7895712
to
1a46e8e
Compare
Cluster Generation A/B Results: |
1a46e8e
to
9f86a30
Compare
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #2898 +/- ##
==========================================
+ Coverage 43.83% 43.87% +0.03%
==========================================
Files 414 414
Lines 41305 41316 +11
==========================================
+ Hits 18105 18126 +21
+ Misses 21507 21499 -8
+ Partials 1693 1691 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just one minor question.
- Fixes incorrect plan name in aws_cc_antrea_test.go. - Adds test to verify that legacy style creation is used when modified overlays are detected. - Includes some cleanups and refactoring. Signed-off-by: Vui Lam <vui@vmware.com>
9f86a30
to
c1e6474
Compare
What this PR does / why we need it
When deem necessary to create cluster using legacy approach, said creation should work.
Also:
Which issue(s) this PR fixes
Fixes #2830
Describe testing done for PR
See provided integration tests
Release note
PR Checklist
Additional information
Special notes for your reviewer
Tests had to work around an issue #2891
by prepopulating a tkr bom config map. Said workaround should be removed as soon as the issue is fixed.