Fixes TKC based cluster template generation issue when TKG_CUSTOM_IMAGE_REPOSITORY is set

[chandrareddyp]

What this PR does / why we need it

why we need it:
In the existing cli overlays, tries to add KubeadmControlPlane and KubeadmConfigTemplate when environment variable TKG_CUSTOM_IMAGE_REPOSITORY set with any value, this is happening even for tkgs use case, which is not valid.

What this PR does:
this PR is to update ytt overlays to exclude KubeadmControlPlane and KubeadmConfigTemplate for tkgs provider, added new condition to check environment variable TKG_CUSTOM_IMAGE_REPOSITORY and the provider type, it includes only for providers ["vsphere", "aws", "azure", "docker"].

Signed-off-by: Chandra Pamuluri cpamuluri@cpamuluri-a01.vmware.com

Which issue(s) this PR fixes

Fixes #2953

Describe testing done for PR

• Build CLI on local with command make build-install-cli-local
• Set environment variable TKG_CUSTOM_IMAGE_REPOSITORY
• unset environment variable SUPPRESS_PROVIDERS_UPDATE
• create tkgs tkc cluster with command - tanzu cluster create -f /tkc.conf --tkr v1.23.5---vmware.1-tkg.1-zshippable -v 9, cluster was created successfully

Release note

Fixed TKC based cluster template generation issue when `TKG_CUSTOM_IMAGE_REPOSITORY` is set

PR Checklist

• Squash the commits into one or a small number of logical commits
  
• Use good commit messages
• Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2954/20220715230041/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[anujc25]

Looks good

[codecov]

Codecov Report

Merging #2954 (6c871aa) into main (5fdc05d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2954      +/-   ##
==========================================
- Coverage   44.00%   43.98%   -0.02%     
==========================================
  Files         416      416              
  Lines       41847    41847              
==========================================
- Hits        18414    18407       -7     
- Misses      21712    21718       +6     
- Partials     1721     1722       +1     

Impacted Files	Coverage Δ
addons/controllers/clusterbootstrap_controller.go	63.28% <0.00%> (-0.62%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdc05d...6c871aa. Read the comment docs.