Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

[release-0.25] Fixed "tanzu cluster get" command to return Classy cluster details on TKGS #3049

Merged

Conversation

prkalle
Copy link
Contributor

@prkalle prkalle commented Aug 1, 2022

… TKGS

  • This is achieved by fixing the "DescribeCluster" API to detect the Classy clusters
    in TKGS and return the overall details of the cluster( same as for TKC cluster).However
    It doesn't show the tree view of the various cluster related resources(same as current behaviour for TKC)

Signed-off-by: Prem Kumar Kalle pkalle@vmware.com

What this PR does / why we need it

This PR fixes the DescribeCluster API to support the Classy clusters in TKGS and return the cluster details. However it doesn't return the cluster related objects that were used to show the tree view in "tanzu cluster get" command.

Which issue(s) this PR fixes

Fixes #3032

Describe testing done for PR

Unit tested and tested locally on TKGS testbed and it was successful.

❯ tanzu cluster get prem-cc01 -n ns01
  NAME       NAMESPACE  STATUS   CONTROLPLANE  WORKERS  KUBERNETES        ROLES   TKR
  prem-cc01  ns01       running  1/1           1/1      v1.23.8+vmware.2  <none>  v1.23.8---vmware.2-tkg.1-zshippable

Release note

 Fixed "tanzu cluster get" command to return Classy cluster details on TKGS

Additional information

Special notes for your reviewer

@prkalle prkalle added area/cli kind/bug PR/Issue related to a bug labels Aug 1, 2022
@prkalle prkalle requested review from a team as code owners August 1, 2022 22:11
@prkalle prkalle requested a review from anujc25 August 1, 2022 22:17
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3049/20220801222346/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-0.25@2520013). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2c726ba differs from pull request most recent head 2e75267. Consider uploading reports for the commit 2e75267 to get more accurate results

@@               Coverage Diff               @@
##             release-0.25    #3049   +/-   ##
===============================================
  Coverage                ?   44.21%           
===============================================
  Files                   ?      416           
  Lines                   ?    42147           
  Branches                ?        0           
===============================================
  Hits                    ?    18637           
  Misses                  ?    21788           
  Partials                ?     1722           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anujc25 anujc25 added the ok-to-merge PRs should be labelled with this before merging label Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3049/20220802171846/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3049/20220802173109/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@anujc25 anujc25 changed the title Fixed "tanzu cluster get" command to return Classy cluster details on TKGS [release-0.25] Fixed "tanzu cluster get" command to return Classy cluster details on TKGS Aug 2, 2022
… TKGS

- This is achieved by fixing the "DescribeCluster" API to detect the Classy clusters
  in TKGS and return the overall details of the cluster( same as for TKC cluster).However
  It doesn't show the tree view of the various cluster related resources(same as current behaviour for TKC)

Signed-off-by: Prem Kumar Kalle <pkalle@vmware.com>
@anujc25 anujc25 merged commit 8284b5a into vmware-tanzu:release-0.25 Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3049/20220802232819/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants