-
Notifications
You must be signed in to change notification settings - Fork 192
[release-0.25] Fixed "tanzu cluster get" command to return Classy cluster details on TKGS #3049
[release-0.25] Fixed "tanzu cluster get" command to return Classy cluster details on TKGS #3049
Conversation
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## release-0.25 #3049 +/- ##
===============================================
Coverage ? 44.21%
===============================================
Files ? 416
Lines ? 42147
Branches ? 0
===============================================
Hits ? 18637
Misses ? 21788
Partials ? 1722 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0160f35
to
c160713
Compare
Cluster Generation A/B Results: |
c160713
to
2c726ba
Compare
Cluster Generation A/B Results: |
… TKGS - This is achieved by fixing the "DescribeCluster" API to detect the Classy clusters in TKGS and return the overall details of the cluster( same as for TKC cluster).However It doesn't show the tree view of the various cluster related resources(same as current behaviour for TKC) Signed-off-by: Prem Kumar Kalle <pkalle@vmware.com>
2c726ba
to
2e75267
Compare
Cluster Generation A/B Results: |
… TKGS
in TKGS and return the overall details of the cluster( same as for TKC cluster).However
It doesn't show the tree view of the various cluster related resources(same as current behaviour for TKC)
Signed-off-by: Prem Kumar Kalle pkalle@vmware.com
What this PR does / why we need it
This PR fixes the DescribeCluster API to support the Classy clusters in TKGS and return the cluster details. However it doesn't return the cluster related objects that were used to show the tree view in "tanzu cluster get" command.
Which issue(s) this PR fixes
Fixes #3032
Describe testing done for PR
Unit tested and tested locally on TKGS testbed and it was successful.
Release note
Additional information
Special notes for your reviewer