-
Notifications
You must be signed in to change notification settings - Fork 192
Display correct error message when passing Cluster based resource without ClusterClass as part of cluster create #3053
Conversation
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3053 +/- ##
==========================================
- Coverage 44.23% 44.14% -0.09%
==========================================
Files 416 416
Lines 42143 42225 +82
==========================================
Hits 18641 18641
- Misses 21780 21868 +88
+ Partials 1722 1716 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1b2df42
to
f1d4365
Compare
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
07ec24c
to
365a7f5
Compare
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
LGTM |
…hout ClusterClass as part of cluster create
365a7f5
to
36da3fe
Compare
Cluster Generation A/B Results: |
LGTM |
What this PR does / why we need it
Currently, when user passes
Cluster
resource as part oftanzu cluster create --file <input.yaml>
and the cluster resource doesn't include ClusterClass as part of.spec.topology.cluster
thrown proper error message.Which issue(s) this PR fixes
Fixes #3054
Describe testing done for PR
--dru-run
output totanzu cluster create --file <manifest.yaml>
and verified the error messageRelease note
Additional information
Special notes for your reviewer