Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

[release-0.25] Update osInfo annotation on Cluster resource during cluster upgrade #3092

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Aug 5, 2022

What this PR does / why we need it

  • This changes updates osInfo annotation on the cluster resource during
    cluster upgrade

Signed-off-by: Anuj Chaudhari anujc@vmware.com

Which issue(s) this PR fixes

Fixes #3090

Describe testing done for PR

  • Added unit tests for patch operations

Manual testing:

  • Create workload cluster with OS_NAME: amazon
  • Verified the osInfo annotation on the cluster resource
  • Upgrade the workload cluster with --os-name ubuntu
  • Cluster was upgraded successfully
  • Verified the annotation on the cluster resource and it was updated to specify ubuntu,20.04,amd64

Release note

Fixed `osInfo` annotation in Cluster CR is not correct after upgrade workload cluster with another os

Additional information

Special notes for your reviewer

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3092/20220805182438/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-0.25@a0ff565). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-0.25    #3092   +/-   ##
===============================================
  Coverage                ?   44.27%           
===============================================
  Files                   ?      417           
  Lines                   ?    42266           
  Branches                ?        0           
===============================================
  Hits                    ?    18714           
  Misses                  ?    21842           
  Partials                ?     1710           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pallavijaini8075 pallavijaini8075 added the ok-to-merge PRs should be labelled with this before merging label Aug 6, 2022
- This changes updates osInfo annotation on the cluster resource during
  cluster upgrade

Signed-off-by: Anuj Chaudhari <anujc@vmware.com>
@anujc25 anujc25 force-pushed the osinfo-to-annotation-during-upgrade-release-0.25 branch from f060915 to b8c4d37 Compare August 7, 2022 23:22
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3092/20220807233137/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anujc25 anujc25 merged commit 5003fae into vmware-tanzu:release-0.25 Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants