Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

[release-0.25] Fix incorrect log message when creating management-cluster #3172

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Aug 22, 2022

What this PR does / why we need it

  • Fix incorrect log message when creating management-cluster
  • Instead of using ClusterClass based management cluster config file has been generated should use Management cluster config file has been generated

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Fix incorrect log message when creating management-cluster

Additional information

Special notes for your reviewer

Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3172/20220822200307/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-0.25@72a11ee). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-0.25    #3172   +/-   ##
===============================================
  Coverage                ?   44.28%           
===============================================
  Files                   ?      417           
  Lines                   ?    42318           
  Branches                ?        0           
===============================================
  Hits                    ?    18739           
  Misses                  ?    21867           
  Partials                ?     1712           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anujc25 anujc25 added ok-to-merge PRs should be labelled with this before merging kind/bug PR/Issue related to a bug labels Aug 23, 2022
@anujc25 anujc25 merged commit 6288c75 into vmware-tanzu:release-0.25 Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants