This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
Skip running cc based pipelines if PR is from a fork #3313
Merged
saji-pivotal
merged 1 commit into
vmware-tanzu:main
from
saji-pivotal:skip-cc-tests-from-prs
Sep 12, 2022
Merged
Skip running cc based pipelines if PR is from a fork #3313
saji-pivotal
merged 1 commit into
vmware-tanzu:main
from
saji-pivotal:skip-cc-tests-from-prs
Sep 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saji-pivotal
force-pushed
the
skip-cc-tests-from-prs
branch
from
September 12, 2022 21:13
26299ea
to
ca400e0
Compare
Codecov Report
@@ Coverage Diff @@
## main #3313 +/- ##
=======================================
Coverage 45.58% 45.58%
=======================================
Files 324 324
Lines 34126 34126
=======================================
Hits 15558 15558
Misses 17102 17102
Partials 1466 1466 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
anujc25
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anujc25
added
kind/failing-test
Categorizes issue or PR as related to a failing test
ok-to-merge
PRs should be labelled with this before merging
labels
Sep 12, 2022
anujc25
suggested changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep the package build and publish part and only skip the tests
saji-pivotal
force-pushed
the
skip-cc-tests-from-prs
branch
from
September 12, 2022 22:08
ca400e0
to
7cd87ed
Compare
anujc25
approved these changes
Sep 12, 2022
vuil
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-not-required
kind/failing-test
Categorizes issue or PR as related to a failing test
ok-to-merge
PRs should be labelled with this before merging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Skips the CC based integration test workflow if the PR is submitted from a fork
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer