Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Read config variable from mgmt cluster into cleanup cluster when deleting mgmt cluster #3395

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Read config variable from mgmt cluster into cleanup cluster when deleting mgmt cluster #3395

merged 1 commit into from
Sep 29, 2022

Conversation

ydp
Copy link

@ydp ydp commented Sep 17, 2022

What this PR does / why we need it

When deleting management cluster, fetch tkg-tkp-tkg-system-values from mgmt cluster and configure it onto the cleanup cluster before install management packages.

Which issue(s) this PR fixes

Fixes #3420

Describe testing done for PR

Release note


Additional information

Special notes for your reviewer

@github-actions
Copy link

Hi @ydp! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better.

@ydp ydp changed the title [WIP][DO NOT MERGE] Copy configvalues from mgmt cluster to cleanup cluster Read config variable from mgmt cluster when deleting Sep 19, 2022
@ydp ydp changed the title Read config variable from mgmt cluster when deleting Read config variable from mgmt cluster into cleanup cluster when deleting mgmt cluster Sep 19, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3395/20220921015137/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #3395 (ac80da0) into main (ed3014a) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3395      +/-   ##
==========================================
+ Coverage   54.21%   54.25%   +0.03%     
==========================================
  Files         107      107              
  Lines       10781    10781              
==========================================
+ Hits         5845     5849       +4     
+ Misses       4467     4463       -4     
  Partials      469      469              
Impacted Files Coverage Δ
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-1.16%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.52% <0.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3395/20220922031422/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@wjun wjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjun wjun added the ok-to-merge PRs should be labelled with this before merging label Sep 29, 2022
@ydp ydp merged commit e6a710a into vmware-tanzu:main Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
4 participants