-
Notifications
You must be signed in to change notification settings - Fork 192
Read config variable from mgmt cluster into cleanup cluster when deleting mgmt cluster #3395
Conversation
Hi @ydp! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better. |
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3395 +/- ##
==========================================
+ Coverage 54.21% 54.25% +0.03%
==========================================
Files 107 107
Lines 10781 10781
==========================================
+ Hits 5845 5849 +4
+ Misses 4467 4463 -4
Partials 469 469
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it
When deleting management cluster, fetch tkg-tkp-tkg-system-values from mgmt cluster and configure it onto the cleanup cluster before install management packages.
Which issue(s) this PR fixes
Fixes #3420
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer