Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

AddonConfig controllers enqueue Cluster by ownerRef #3510

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented Sep 29, 2022

What this PR does / why we need it

AddonConfig controllers enqueue Cluster by ownerRef instead of addon name

Which issue(s) this PR fixes

Fixes ##3509

Describe testing done for PR

Release note

AddonConfig controllers enqueue Cluster by ownerRef

Additional information

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #3510 (d7dcce0) into main (e6a710a) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   45.55%   45.24%   -0.31%     
==========================================
  Files         360      370      +10     
  Lines       38870    39307     +437     
==========================================
+ Hits        17706    17786      +80     
- Misses      19560    19906     +346     
- Partials     1604     1615      +11     
Impacted Files Coverage Δ
cli/runtime/plugin/usage.go 50.00% <0.00%> (-20.59%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.29% <0.00%> (-1.61%) ⬇️
cli/core/pkg/cli/usage.go 62.85% <0.00%> (-0.11%) ⬇️
cli/core/pkg/command/root.go 0.00% <0.00%> (ø)
cmd/cli/plugin-admin/builder/init.go 40.00% <0.00%> (ø)
...cli/plugin-admin/builder/command/publish/helper.go 32.11% <0.00%> (ø)
...cli/plugin-admin/codegen/generators/feature/gen.go 38.09% <0.00%> (ø)
cli/runtime/component/colorable-tty.go 54.16% <0.00%> (ø)
...md/cli/plugin-admin/builder/command/publish/oci.go 0.00% <0.00%> (ø)
.../plugin-admin/builder/command/publish/publisher.go 0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@vijaykatam vijaykatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A test for one of the addons would be nice to have.

Copy link
Contributor

@12345lcr 12345lcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vijaykatam vijaykatam added the ok-to-merge PRs should be labelled with this before merging label Oct 4, 2022
@lubronzhan lubronzhan merged commit 94a4dfb into vmware-tanzu:main Oct 4, 2022
@lubronzhan lubronzhan deleted the fix_enqueue_handler branch October 4, 2022 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants