Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

add default toleration in metrics-server secret #3553

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

ggpaue
Copy link
Contributor

@ggpaue ggpaue commented Oct 4, 2022

What this PR does / why we need it

add default toleration in metrics-server secret

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Add control plane toleration to metrics-server

Additional information

Special notes for your reviewer

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3553/20221004230354/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #3553 (9e81dcf) into main (94a4dfb) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3553      +/-   ##
==========================================
+ Coverage   45.28%   45.32%   +0.03%     
==========================================
  Files         370      370              
  Lines       39306    39306              
==========================================
+ Hits        17801    17814      +13     
+ Misses      19894    19884      -10     
+ Partials     1611     1608       -3     
Impacted Files Coverage Δ
addons/controllers/clusterbootstrap_controller.go 65.45% <0.00%> (+0.59%) ⬆️
...ons/controllers/packageinstallstatus_controller.go 79.15% <0.00%> (+1.15%) ⬆️
addons/controllers/machine_controller.go 68.68% <0.00%> (+3.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vijaykatam
Copy link
Contributor

Lets fill out the PR template and this should be good to merge.

@shyaamsn shyaamsn added the ok-to-merge PRs should be labelled with this before merging label Oct 5, 2022
@ggpaue ggpaue requested a review from vijaykatam October 5, 2022 21:51
@ggpaue ggpaue merged commit d93987a into main Oct 5, 2022
@ggpaue ggpaue deleted the gguanpeng/metrics-server-tolerations-new branch October 5, 2022 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants