This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
cluster_bootstrap: Short requeue if CRD not found on remote cluster #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed! Build no: 2963 |
Codecov Report
@@ Coverage Diff @@
## main #3713 +/- ##
==========================================
- Coverage 46.23% 45.31% -0.93%
==========================================
Files 400 425 +25
Lines 39620 41180 +1560
==========================================
+ Hits 18319 18659 +340
- Misses 19615 20814 +1199
- Partials 1686 1707 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
On clusters where kapp is taking a long time to get installed (slow registries etc...), cluster_bootstrap controller may end up in exponential backoff because some CRDs do not exist yet on the remote cluster. This change checks for this particular error, and requeues the cluster for retry after 10s. Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
cluster-bootstrap-reconciliation
branch
from
3593f55
to
a92e21c
Compare
|
/lgtm |
HanFa
approved these changes
Oct 20, 2022
|
@vijaykatam can you take a look? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #3698
Describe testing done for PR
Will be running
/test install-vc7Release note
Additional information
Special notes for your reviewer