-
Notifications
You must be signed in to change notification settings - Fork 192
Splitting jsonpatches on a conditional antrea installation for windows #3867
Conversation
5dcd360
to
7826048
Compare
Cluster Generation A/B Results: |
7826048
to
f480546
Compare
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3867 +/- ##
==========================================
- Coverage 46.93% 46.03% -0.91%
==========================================
Files 402 427 +25
Lines 40203 41754 +1551
==========================================
+ Hits 18869 19221 +352
- Misses 19582 20765 +1183
- Partials 1752 1768 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/test install-vc7 |
Tests failed! Build no: 3158 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, One change, please bump the annotation at line 174 of base.yml identifier.cc.vmware.com: tanzu-vsphere-default-0.0.2
this version is used by the UI team to track if changes have been made to the variable schema.
f480546
to
649523a
Compare
Cluster Generation A/B Results: |
649523a
to
702bc11
Compare
Cluster Generation A/B Results: |
What this PR does / why we need it
Splitting conditional JSON patches for Antrea and Windows installations, this will allow operator to use CNI:none and do not have antrea by default in the windows node.
Which issue(s) this PR fixes
Fixes #3866
Describe testing done for PR
Manual tests with the CC were made
Release note
Additional information
Special notes for your reviewer