Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Management cluster plugin: Add support for extra manifests #3886

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

HanFa
Copy link
Contributor

@HanFa HanFa commented Nov 10, 2022

What this PR does / why we need it

Required by and cherry-picked from the Oracle Support, #3557, documented in #3600

This PR allows extra directory of manifests to be applied at bootstrap. To be used as an escape hatch for custom TKrs.

Co-authored-by: Fang Han fhan@vmware.com
Signed-off-by: Naadir Jeewa jeewan@vmware.com

Example Usage:

tanzu management-cluster create -f ~/mc.yaml --additional-tkg-system-manifests ~/tkr-oci

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Add support for applying extra manifests during management cluster bootstrap. A directory of manifests can be applied to the tkg-system namespace just before cluster creation using `--additional-tkg-system-manifests`

Additional information

Special notes for your reviewer

@HanFa HanFa requested review from a team as code owners November 10, 2022 00:55
@HanFa HanFa changed the title Oracle - Management cluster plugin: Add support for extra manifests Oracle Support - Management cluster plugin: Add support for extra manifests Nov 10, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3886/20221110010250/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3886/20221110011611/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3886/20221110012551/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3886/20221110014725/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Allows extra directory of manifests to be applied at bootstrap.
To be used as an escape hatch for custom TKrs.

Co-authored-by: Fang Han <fhan@vmware.com>
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3886/20221110023203/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Member

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

tkg/clusterclient/clusterclient.go Show resolved Hide resolved
@DanielXiao
Copy link
Contributor

There are still failed checks.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #3886 (1518a16) into main (a2962f3) will decrease coverage by 0.89%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3886      +/-   ##
==========================================
- Coverage   46.93%   46.03%   -0.90%     
==========================================
  Files         402      427      +25     
  Lines       40203    41780    +1577     
==========================================
+ Hits        18869    19234     +365     
- Misses      19582    20781    +1199     
- Partials     1752     1765      +13     
Impacted Files Coverage Δ
tkg/client/client.go 81.25% <ø> (ø)
tkg/client/init.go 0.00% <0.00%> (ø)
tkg/clusterclient/clusterclient.go 48.27% <0.00%> (-0.39%) ⬇️
tkg/tkgctl/init.go 0.00% <0.00%> (ø)
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) ⬇️
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-1.16%) ⬇️
cmd/cli/plugin/cluster/osimage_oracle.go 3.20% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HanFa
Copy link
Contributor Author

HanFa commented Nov 10, 2022

There are still failed checks.

looks like it is flake from CAPD pipeline. it succeeds after retry

@DanielXiao DanielXiao added the ok-to-merge PRs should be labelled with this before merging label Nov 11, 2022
@HanFa HanFa merged commit c6afa0f into main Nov 11, 2022
@HanFa HanFa deleted the topic/fhan/extra-manifests branch November 11, 2022 23:21
xiujuanx pushed a commit that referenced this pull request Nov 14, 2022
Allows extra directory of manifests to be applied at bootstrap.
To be used as an escape hatch for custom TKrs.

Co-authored-by: Fang Han <fhan@vmware.com>
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
Co-authored-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable randomvariable changed the title Oracle Support - Management cluster plugin: Add support for extra manifests Management cluster plugin: Add support for extra manifests Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants