This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Enable feature-flag for context-target by default
#4081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test install-vc7 |
Codecov Report
@@ Coverage Diff @@
## main #4081 +/- ##
=======================================
Coverage ? 47.77%
=======================================
Files ? 469
Lines ? 45475
Branches ? 0
=======================================
Hits ? 21726
Misses ? 21697
Partials ? 2052
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
LGTM. |
mpanchajanya
approved these changes
Dec 2, 2022
chandrareddyp
approved these changes
Dec 2, 2022
|
nit: in your PR description: Still thinking if there is a better name for the flag. using -v2 when the original was never publicly exposed feels weird. |
vuil
approved these changes
Dec 2, 2022
vuil
added
area/core-cli
ok-to-merge
|
given the original flag was actually out, the alternative name, while not pretty, seems reasonable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR enables the Context/Target feature-flag by default.
This change requires rename of the feature-flag to
context-target-v2to make sure default value gets update in the user'sconfig.yamlifcontext-targetfeature-flag already exists.config.yamlthan current logic does not change the value.Which issue(s) this PR fixes
Fixes #3653
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer