Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

support configuring system wide proxy for vsphere #4345

Merged
merged 4 commits into from
Feb 11, 2023
Merged

support configuring system wide proxy for vsphere #4345

merged 4 commits into from
Feb 11, 2023

Conversation

XudongLiuHarold
Copy link
Member

Signed-off-by: Xudong Liu xudongl@vmware.com

What this PR does / why we need it

  • support configuring system wide proxy for vsphere

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

users can configure system-wide proxy when vsphere as the cloud provider

Additional information

Special notes for your reviewer

@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4345/20230209033537/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4345/20230209034515/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #4345 (492d43b) into main (1d6fbf7) will decrease coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4345      +/-   ##
==========================================
- Coverage   49.53%   48.64%   -0.89%     
==========================================
  Files         452      482      +30     
  Lines       44986    47106    +2120     
==========================================
+ Hits        22284    22917     +633     
- Misses      20580    22017    +1437     
- Partials     2122     2172      +50     
Impacted Files Coverage Δ
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-2.32%) ⬇️
addons/controllers/addon_controller.go 63.40% <0.00%> (-2.07%) ⬇️
...lugin/isolated-cluster/fakes/client_imgpkg_fake.go 32.75% <0.00%> (ø)
cmd/cli/plugin/cluster/kubeconfig_get.go 8.82% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
...li/plugin/isolated-cluster/imgpkginterface/util.go 50.00% <0.00%> (ø)
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
cmd/cli/plugin/cluster/get_machinehealthcheck.go 11.42% <0.00%> (ø)
...olated-cluster/imagepushop/publishimagesfromtar.go 73.17% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4345/20230209050835/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@alfredthenarwhal
Copy link
Collaborator

@XudongLiuHarold: /test install-vc7
Commit: 17520c3

Tests failed! Build no: 4025

@lubronzhan lubronzhan added cherry-pick/release-0.28 PRs to be cherry-picked into release-0.28 branch ok-to-merge PRs should be labelled with this before merging labels Feb 9, 2023
@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4345/20230210005757/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@alfredthenarwhal
Copy link
Collaborator

@XudongLiuHarold: /test install-vc7
Commit: 1417dab

Tests failed! Build no: 4034

Signed-off-by: Xudong Liu <xudongl@vmware.com>
Signed-off-by: Xudong Liu <xudongl@vmware.com>
Signed-off-by: Xudong Liu <xudongl@vmware.com>
Signed-off-by: Xudong Liu <xudongl@vmware.com>
@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4345/20230211021446/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@alfredthenarwhal
Copy link
Collaborator

@XudongLiuHarold: /test install-vc7
Commit: 492d43b

Tests failed! Build no: 4039

@XudongLiuHarold XudongLiuHarold merged commit 4c778d0 into vmware-tanzu:main Feb 11, 2023
XudongLiuHarold added a commit that referenced this pull request Feb 11, 2023
* support configuring system-wide proxy

Signed-off-by: Xudong Liu <xudongl@vmware.com>
XudongLiuHarold added a commit that referenced this pull request Feb 11, 2023
* support configuring system-wide proxy

Signed-off-by: Xudong Liu <xudongl@vmware.com>
XudongLiuHarold added a commit that referenced this pull request Feb 13, 2023
* support configuring system-wide proxy

Signed-off-by: Xudong Liu <xudongl@vmware.com>
XudongLiuHarold added a commit that referenced this pull request Feb 13, 2023
* support configuring system-wide proxy

Signed-off-by: Xudong Liu <xudongl@vmware.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-pick/release-0.28 PRs to be cherry-picked into release-0.28 branch cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants