Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY user env setting #4383

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

imikushin
Copy link
Contributor

What this PR does / why we need it

tanzu config set env.TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY "true" doesn't affect the TKR Source Controller without this change.

Which issue(s) this PR fixes

N/A

Describe testing done for PR

Release note

Fix TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY user env setting for the TKR Source Controller.

Additional information

Special notes for your reviewer

tanzu config set env.TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY "true"
doesn't affect the TKR Source Controller without this change.

Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
@imikushin imikushin requested review from a team as code owners February 14, 2023 21:52
@imikushin imikushin added ok-to-merge PRs should be labelled with this before merging area/tkr labels Feb 14, 2023
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4383/20230214215848/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4383/20230215234014/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@imikushin imikushin added the cherry-pick/release-0.28 PRs to be cherry-picked into release-0.28 branch label Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #4383 (28c33b7) into main (af08710) will decrease coverage by 0.86%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##             main    #4383      +/-   ##
==========================================
- Coverage   49.51%   48.65%   -0.86%     
==========================================
  Files         452      482      +30     
  Lines       44986    47136    +2150     
==========================================
+ Hits        22273    22936     +663     
- Misses      20588    22026    +1438     
- Partials     2125     2174      +49     
Impacted Files Coverage Δ
tkg/managementcomponents/helper.go 92.61% <96.42%> (+0.68%) ⬆️
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-1.16%) ⬇️
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/get_node_pools.go 10.52% <0.00%> (ø)
.../cli/plugin/cluster/get_machinehealthcheck_node.go 9.30% <0.00%> (ø)
.../cli/plugin/cluster/set_machinehealthcheck_node.go 23.33% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
.../isolated-cluster/imgpkginterface/client_imgpkg.go 0.00% <0.00%> (ø)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imikushin imikushin merged commit 9c69599 into main Feb 17, 2023
@imikushin imikushin deleted the topic/imikushin/tkr-skip-verify-registry-cert branch February 17, 2023 08:24
github-actions bot pushed a commit that referenced this pull request Feb 17, 2023
* Fix TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY user env setting

tanzu config set env.TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY "true"
doesn't affect the TKR Source Controller without this change.

Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
@alfredthenarwhal
Copy link
Collaborator

Created cherry-pick PR #4407

imikushin pushed a commit that referenced this pull request Feb 18, 2023
…) (#4407)

* Fix TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY user env setting

tanzu config set env.TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY "true"
doesn't affect the TKR Source Controller without this change.

Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
mohitsharma-in pushed a commit to mohitsharma-in/tanzu-framework that referenced this pull request Feb 20, 2023
…are-tanzu#4383)

* Fix TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY user env setting

tanzu config set env.TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY "true"
doesn't affect the TKR Source Controller without this change.

Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
m1zzx2 pushed a commit that referenced this pull request Mar 27, 2023
* Fix TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY user env setting

tanzu config set env.TKG_CUSTOM_IMAGE_REPOSITORY_SKIP_TLS_VERIFY "true"
doesn't affect the TKR Source Controller without this change.

Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tkr cherry-pick/release-0.28 PRs to be cherry-picked into release-0.28 branch cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants