Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Enable Configuration for net-permissions #4412

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Conversation

nikhilbarge
Copy link
Contributor

@nikhilbarge nikhilbarge commented Feb 20, 2023

What this PR does / why we need it

This pr will enable tkgm user to confgure csi net-permissions

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

This pr will enable tkgm user to confgure csi net-permissions 

Additional information

Special notes for your reviewer

@nikhilbarge nikhilbarge requested review from a team as code owners February 20, 2023 04:02
@nikhilbarge nikhilbarge added the cherry-pick/release-0.28 PRs to be cherry-picked into release-0.28 branch label Feb 20, 2023
@nikhilbarge nikhilbarge requested a review from a team as a code owner February 20, 2023 06:40
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4412/20230220064754/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4412/20230220084825/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #4412 (708d33d) into main (e8be7cd) will decrease coverage by 0.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4412      +/-   ##
==========================================
- Coverage   49.65%   48.72%   -0.93%     
==========================================
  Files         452      482      +30     
  Lines       45044    47164    +2120     
==========================================
+ Hits        22366    22982     +616     
- Misses      20563    22011    +1448     
- Partials     2115     2171      +56     
Impacted Files Coverage Δ
addons/controllers/clusterbootstrap_controller.go 64.58% <0.00%> (-1.55%) ⬇️
cmd/cli/plugin/tkr/v1alpha3/os.go 73.50% <0.00%> (-0.86%) ⬇️
.../isolated-cluster/imgpkginterface/client_imgpkg.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/main.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/credentials_update.go 8.73% <0.00%> (ø)
...cluster/delete_machinehealthcheck_control_plane.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
cmd/cli/plugin/cluster/kubeconfig_get.go 8.82% <0.00%> (ø)
cmd/cli/plugin/cluster/get_machinehealthcheck.go 11.42% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nikhilbarge
Copy link
Contributor Author

/test install-vc7

@nikhilbarge
Copy link
Contributor Author

/test upgrade-vc7

@alfredthenarwhal
Copy link
Collaborator

@nikhilbarge: /test install-vc7
Commit: 708d33d

Tests failed! Build no: 4154

@alfredthenarwhal
Copy link
Collaborator

@nikhilbarge: /test upgrade-vc7
Commit: 708d33d

Tests failed! Build no: 4156

@nikhilbarge
Copy link
Contributor Author

/test install-vc7

@nikhilbarge
Copy link
Contributor Author

/test upgrade-vc7

@nikhilbarge
Copy link
Contributor Author

/test install-vc7

@alfredthenarwhal
Copy link
Collaborator

@nikhilbarge: /test upgrade-vc7
Commit: 708d33d

Tests failed! Build no: 4160

@alfredthenarwhal
Copy link
Collaborator

@nikhilbarge: /test install-vc7
Commit: 708d33d

Tests failed! Build no: 4161

@nikhilbarge
Copy link
Contributor Author

/test install-vc7 --graph tkg-v2.2.0-zshippable.yaml

@alfredthenarwhal
Copy link
Collaborator

@nikhilbarge: /test install-vc7 --graph tkg-v2.2.0-zshippable.yaml
Commit: 708d33d

Tests passed! Build no: 4176

@nikhilbarge
Copy link
Contributor Author

/test upgrade-vc7 --graph tkg-v2.2.0-zshippable.yaml

@alfredthenarwhal
Copy link
Collaborator

@nikhilbarge: /test upgrade-vc7 --graph tkg-v2.2.0-zshippable.yaml
Commit: 708d33d

Tests failed! Build no: 4183

@nikhilbarge nikhilbarge removed the cherry-pick/release-0.28 PRs to be cherry-picked into release-0.28 branch label Feb 28, 2023
@nikhilbarge
Copy link
Contributor Author

/test install-vc7 --graph tkg-v2.2.0-zshippable.yaml

@alfredthenarwhal
Copy link
Collaborator

@nikhilbarge: /test install-vc7 --graph tkg-v2.2.0-zshippable.yaml
Commit: 708d33d

Tests failed! Build no: 4287

@nikhilbarge
Copy link
Contributor Author

/test install-vc7 --graph tkg-v2.2.0-zshippable.yaml

@alfredthenarwhal
Copy link
Collaborator

@nikhilbarge: /test install-vc7 --graph tkg-v2.2.0-zshippable.yaml
Commit: 708d33d

Tests passed! Build no: 4298

@wjun wjun added the ok-to-merge PRs should be labelled with this before merging label Mar 8, 2023
@nikhilbarge nikhilbarge merged commit 0eee17b into main Mar 8, 2023
@nikhilbarge nikhilbarge deleted the configure-netpermissions branch March 8, 2023 09:21
m1zzx2 pushed a commit that referenced this pull request Mar 27, 2023
* enable netpermissions configuration for vsphere-csi
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants