This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Skip reconciliation for cpi config templates #4437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a vsphere cpi config is annotated as template, it should not be reconciled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a vsphere cpi config is annotated as template,
it should not be reconciled.
What this PR does / why we need it
if a vsphere cpi config is annotated as template it should not be reconciled. Attempting to do so results in an
error that may confuse users.
Which issue(s) this PR fixes
Fixes #4435
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer