This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
getGVR should only fail if no GroupVersionResource is found #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adduarte
force-pushed
the
topic/aduarte/ignore_discoverfailed_error
branch
from
a7635f4
to
ac3bc57
Compare
Codecov Report
@@ Coverage Diff @@
## main #4459 +/- ##
==========================================
- Coverage 49.66% 48.76% -0.91%
==========================================
Files 452 482 +30
Lines 45152 47229 +2077
==========================================
+ Hits 22425 23031 +606
- Misses 20596 22014 +1418
- Partials 2131 2184 +53
... and 39 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adduarte
force-pushed
the
topic/aduarte/ignore_discoverfailed_error
branch
from
243cbac
to
ac3bc57
Compare
adduarte
commented
Mar 9, 2023
adduarte
commented
Mar 9, 2023
adduarte
changed the title
adduarte
commented
Mar 9, 2023
adduarte
force-pushed
the
topic/aduarte/ignore_discoverfailed_error
branch
from
ac3bc57
to
0cc0817
Compare
adduarte
commented
Mar 9, 2023
adduarte
force-pushed
the
topic/aduarte/ignore_discoverfailed_error
branch
2 times, most recently
from
2e44d41
to
9a52c4c
Compare
|
/test install-vc7 |
adduarte
changed the title
|
/test install-vc7 |
|
/test install-vc7 |
adduarte
force-pushed
the
topic/aduarte/ignore_discoverfailed_error
branch
from
9a52c4c
to
85afe58
Compare
|
/test install-vc7 |
|
/test install-vc7 |
The call to ServerPreferredResources could return an error even thoug the reource list is not empty. This should not be a failure if the reource list is not empty. This patch checks that if the error returned by ServerPreferredResoruces is "ErrorGroupDiscoveryFailed", the getGVR will only return a error (failure) if the resulting resource list is also empty.
adduarte
force-pushed
the
topic/aduarte/ignore_discoverfailed_error
branch
from
85afe58
to
fc33b8f
Compare
|
/test install-vc7 |
|
install-vc7 test succeeded: https://gitlab.eng.vmware.com/TKG/bolt/bolt-release-yamls/-/merge_requests/4446 |
adduarte
added
ok-to-merge
maralavi
approved these changes
Mar 16, 2023
m1zzx2
pushed a commit
that referenced
this pull request
Mar 27, 2023
The call to ServerPreferredResources could return an error even thoug the reource list is not empty. This should not be a failure if the reource list is not empty. This patch checks that if the error returned by ServerPreferredResoruces is "ErrorGroupDiscoveryFailed", the getGVR will only return a error (failure) if the resulting resource list is also empty.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to ServerPreferredResources could return an err != nil even though the resource list is not empty.
getGVR should not report a failure if the resource list does contain a matching GroupVersionResource, even if ServerPreferredResources returned err != nil.
What this PR does / why we need it
This patch modifies getGVR so it only return a error (failure) if it cannot find a matching GroupVersionResource.
Which issue(s) this PR fixes
Fixes #4460
Describe testing done for PR
Unit test created and executed.
ran deployed to vsphere 7 platform.
Release note
Additional information
Special notes for your reviewer