Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Ensure cluster-api-ipam-provider-in-cluster respects the imagePath field in the BOM #4529

Merged

Conversation

christianang
Copy link
Contributor

@christianang christianang commented Mar 28, 2023

What this PR does / why we need it

cluster-api-ipam-provider-in-cluster does not respect the imagePath field in the bom like other components do. This PR fixes that.

Which issue(s) this PR fixes

Describe testing done for PR

Created a management cluster locally with a tkg bom that changed the in-cluster ipam provider image to use a sandbox build in the imagePath.

Release note

cluster-api-ipam-provider-in-cluster respects the imagePath field from the TKG BOM

Additional information

Special notes for your reviewer

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4529/20230328233919/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@christianang christianang marked this pull request as ready for review March 28, 2023 23:45
@christianang christianang requested review from a team as code owners March 28, 2023 23:45
@christianang christianang force-pushed the fix-image-path-for-ipam-provider branch from a6748c3 to 027d677 Compare March 29, 2023 21:37
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4529/20230329214855/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Co-authored-by: Tyler Schultz <tschultz@vmware.com>
@christianang christianang force-pushed the fix-image-path-for-ipam-provider branch from 027d677 to b929ac8 Compare March 30, 2023 00:00
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4529/20230330000916/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #4529 (b929ac8) into main (fe8dd98) will decrease coverage by 0.85%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4529      +/-   ##
==========================================
- Coverage   49.82%   48.97%   -0.85%     
==========================================
  Files         453      483      +30     
  Lines       45395    47519    +2124     
==========================================
+ Hits        22617    23273     +656     
- Misses      20626    22049    +1423     
- Partials     2152     2197      +45     
Impacted Files Coverage Δ
tkg/tkgconfigupdater/images.go 83.17% <100.00%> (+0.65%) ⬆️

... and 35 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christianang christianang added the ok-to-merge PRs should be labelled with this before merging label Mar 30, 2023
@christianang christianang merged commit 13d352d into vmware-tanzu:main Mar 30, 2023
@tylerschultz tylerschultz deleted the fix-image-path-for-ipam-provider branch April 3, 2023 18:14
@tylerschultz tylerschultz restored the fix-image-path-for-ipam-provider branch April 3, 2023 18:14
@tylerschultz tylerschultz deleted the fix-image-path-for-ipam-provider branch April 3, 2023 18:14
@tylerschultz tylerschultz restored the fix-image-path-for-ipam-provider branch April 3, 2023 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants