New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove naked returns #959

Closed

carlisia opened this issue Oct 18, 2018 · 1 comment · Fixed by #960

Labels

Enhancement/Dev Good first issue kind/tech-debt Size/S

Contributor

carlisia commented Oct 18, 2018

https://github.com/heptio/ark/blob/17b3a3b0730a23e1903663a21efb511ac4e1f95f/pkg/controller/restore_controller.go#L491

The return values for this function should be changed to not be naked returns.

carlisia added Enhancement/Dev Good first issue Size/S labels

nrb added the kind/tech-debt label

Atul9 mentioned this issue

#959 Update restoreController runRestore function to specify return arguments #960

Merged

Contributor

Atul9 commented Oct 18, 2018

@carlisia I have opened up a PR for this #960

ncdc closed this as completed in #960

ncdc added a commit that referenced this issue


          Merge pull request #960 from Atul9/return-arguments

d0937a3

#959 Update restoreController runRestore function to specify return arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment