Remove default token from all service accounts #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will fix the imports issue - 1 sec |
ncdc
force-pushed
the
remove-default-token-from-all-service-accounts
branch
from
b557ea1
to
c8cf413
Compare
|
Hopefully travis will be happy now! |
|
@skriss I don't remember if I tested this in minikube or not. I think I did but am not 100% sure. |
Instead of only removing the default token from a service account when it already exists in the cluster, always remove it. If the service account already exists, continue to do the merging logic. Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
ncdc
force-pushed
the
remove-default-token-from-all-service-accounts
branch
from
c8cf413
to
62d8c64
Compare
|
@skriss changelog updated. Tested just now on minikube. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only removing the default token from a service account when
it already exists in the cluster, always remove it. If the service
account already exists, continue to do the merging logic.
Fixes #1047
Signed-off-by: Andy Goldstein andy.goldstein@gmail.com