Refactor image builds to use buildx for multi arch image building #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrb
reviewed
Jul 23, 2020
|
Thanks for this @RobReus! I'll look at it in more detail later today. For now, can you double check to make sure that all changed files have their copyright year set to 2020? |
Signed-off-by: Rob Reus <rob@devrobs.nl>
|
@nrb I have updated the copyright of the files I touched with this PR. |
ashish-amarnath
suggested changes
Jul 23, 2020
There was a problem hiding this comment.
@RobReus Thank you for picking this up!
The changes makes sense to me. But I've not been able to build a container from this PR.
Can you please clarify the buildx installation and also the platforms you've been able to build this in?
Signed-off-by: Rob Reus <rob@devrobs.nl>
Signed-off-by: Rob Reus <rob@devrobs.nl>
There was a problem hiding this comment.
@RobReus Can you also please add a changelog file?
https://github.com/vmware-tanzu/velero/pull/2754/checks?check_run_id=907666453
Signed-off-by: Rob Reus <rob@devrobs.nl>
Signed-off-by: Rob Reus <rob@devrobs.nl>
|
@ashish-amarnath I have updated the contribution docs on building the container images. I have also implemented the feedback given. Let me know if there's anything else you want to discuss or see changed. |
Signed-off-by: Rob Reus <rob@devrobs.nl>
nrb
approved these changes
Aug 4, 2020
ashish-amarnath
approved these changes
Aug 4, 2020
georgettica
pushed a commit
to georgettica/velero
that referenced
this pull request
Dec 23, 2020
…ware-tanzu#2754) * Refactor image builds to use buildx for multi arch image building Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding image build sanity checks to Makefile Signed-off-by: Rob Reus <rob@devrobs.nl> * Making locally building of docker images possible Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding docs on building container images using buildx Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding changelog and implementing feedback from PR Signed-off-by: Rob Reus <rob@devrobs.nl> * Making GOPROXY used in the build containers configurable Signed-off-by: Rob Reus <rob@devrobs.nl>
georgettica
pushed a commit
to georgettica/velero
that referenced
this pull request
Jan 26, 2021
…ware-tanzu#2754) * Refactor image builds to use buildx for multi arch image building Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding image build sanity checks to Makefile Signed-off-by: Rob Reus <rob@devrobs.nl> * Making locally building of docker images possible Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding docs on building container images using buildx Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding changelog and implementing feedback from PR Signed-off-by: Rob Reus <rob@devrobs.nl> * Making GOPROXY used in the build containers configurable Signed-off-by: Rob Reus <rob@devrobs.nl>
vadasambar
pushed a commit
to vadasambar/velero
that referenced
this pull request
Feb 3, 2021
…ware-tanzu#2754) * Refactor image builds to use buildx for multi arch image building Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding image build sanity checks to Makefile Signed-off-by: Rob Reus <rob@devrobs.nl> * Making locally building of docker images possible Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding docs on building container images using buildx Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding changelog and implementing feedback from PR Signed-off-by: Rob Reus <rob@devrobs.nl> * Making GOPROXY used in the build containers configurable Signed-off-by: Rob Reus <rob@devrobs.nl>
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
…ware-tanzu#2754) * Refactor image builds to use buildx for multi arch image building Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding image build sanity checks to Makefile Signed-off-by: Rob Reus <rob@devrobs.nl> * Making locally building of docker images possible Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding docs on building container images using buildx Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding changelog and implementing feedback from PR Signed-off-by: Rob Reus <rob@devrobs.nl> * Making GOPROXY used in the build containers configurable Signed-off-by: Rob Reus <rob@devrobs.nl>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
…ware-tanzu#2754) * Refactor image builds to use buildx for multi arch image building Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding image build sanity checks to Makefile Signed-off-by: Rob Reus <rob@devrobs.nl> * Making locally building of docker images possible Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding docs on building container images using buildx Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding changelog and implementing feedback from PR Signed-off-by: Rob Reus <rob@devrobs.nl> * Making GOPROXY used in the build containers configurable Signed-off-by: Rob Reus <rob@devrobs.nl>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…ware-tanzu#2754) * Refactor image builds to use buildx for multi arch image building Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding image build sanity checks to Makefile Signed-off-by: Rob Reus <rob@devrobs.nl> * Making locally building of docker images possible Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding docs on building container images using buildx Signed-off-by: Rob Reus <rob@devrobs.nl> * Adding changelog and implementing feedback from PR Signed-off-by: Rob Reus <rob@devrobs.nl> * Making GOPROXY used in the build containers configurable Signed-off-by: Rob Reus <rob@devrobs.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2466 , Fixes #2486 , Closes #2566
This change introduces buildx to build multi arch container images.
Only the container image building is affected by this change, all other functionality (including locally building) remains the same.
Would love to get some feedback on this. We would probably improve it further to reduce build times. Right now the GitHub workflow takes about the same amount of time as before, even though images are now built in parallel. I noticed that cross compiling within the new way of doing it went from 90 seconds to around 300 seconds. I feel like we can win plenty of time by making the cross compile of the velero binary more efficient.
Succesful workflow on my fork: https://github.com/RobReus/velero/actions/runs/180022436 (most recent ones failed due to my credentials now having access to the velero registry).