Migrate backup sync controller from code-generator to kubebuilder #5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
backup_sync_refact
branch
from
9db330f to
dfc781b
Compare
|
This is some behavior change of backup sync controller after this PR. This is because backup sync controller is triggered by timer, not event, before this change. After this change, reconciler is triggered by PeriodicalEnqueueSource, which will list BSL in cluster, and enqueue the first BSL. |
blackpiglet
force-pushed
the
backup_sync_refact
branch
6 times, most recently
from
edbafe6 to
9b171a0
Compare
1. use kubebuilder's reconcile logic to replace controller's old logic. 2. use ginkgo and gomega to replace testing. 3. modify BSL reconciler registration method. Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
blackpiglet
force-pushed
the
backup_sync_refact
branch
from
9b171a0 to
d8fc5f6
Compare
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
blackpiglet
force-pushed
the
backup_sync_refact
branch
from
f6be0ec to
3c3cfc6
Compare
ywk253100
reviewed
Aug 24, 2022
| &velerov1api.BackupStorageLocationList{}, | ||
| backupSyncReconcilePeriod, | ||
| // Only enqueue the first BSL | ||
| func(object client.Object) bool { |
There was a problem hiding this comment.
How about that we change the Reconciler to only handle one BSL at a time, so that we can enqueue all items rather than just the first one. The current code in this PR seems a little weird, the PeriodicalEnqueueSource is just used as a signal, and the List is called n+1 times(n is the count of BSL).
For the BSL ordering, how about we define an OrderFunc for the PeriodicalEnqueueSource so that the caller can customize the order of the items.
There was a problem hiding this comment.
Basically I agree with your suggestion.
Per my understanding, since adding a new orderFunc, we need a default orderFunc to return input list as output for other controller using PeriodicalEnqueueSource.
There was a problem hiding this comment.
How about that we define an Option struct for the PeriodicalEnqueueSource, the Option is extensible easily without modifying the caller code when adding new features to it. Currently, it contains only FilterFunc and OrderFunc
blackpiglet
force-pushed
the
backup_sync_refact
branch
from
f52e1f3 to
d0881e4
Compare
ywk253100
reviewed
Aug 26, 2022
| err := b.client.Get(ctx, req.NamespacedName, location) | ||
| if err != nil { | ||
| log.WithError(err).Errorf("BackupStorageLocation %s is not found", req.NamespacedName.String()) | ||
| return ctrl.Result{Requeue: false}, err |
There was a problem hiding this comment.
Should return a nil error or the obj will be put into the queue again
ywk253100
reviewed
Aug 26, 2022
| syncPeriod := b.defaultBackupSyncPeriod | ||
| if location.Spec.BackupSyncPeriod != nil { | ||
| syncPeriod = location.Spec.BackupSyncPeriod.Duration | ||
| if syncPeriod == 0 { |
There was a problem hiding this comment.
How about putting the checking logic into a FilterFunc of PeriodicalEnqueueSource so that no reconciling will be triggered?
ywk253100
reviewed
Aug 26, 2022
| return locationList.Items | ||
| } | ||
| lastSync := location.Status.LastSyncedTime | ||
| if lastSync != nil { |
There was a problem hiding this comment.
Suggest put the checking logic into a FilterFunc of PeriodicalEnqueueSource
ywk253100
reviewed
Aug 26, 2022
| // Reconcile syncs between the backups in cluster and backups metadata in object store. | ||
| func (b *backupSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { | ||
| log := b.logger.WithField("controller", BackupSync) | ||
| log.Debug("Checking for existing backup storage locations to sync into cluster.") |
There was a problem hiding this comment.
Seems this log message isn't reasonable anymore
ywk253100
reviewed
Aug 26, 2022
|
|
||
| // backupSyncSourceOrderFunc returns a new slice with the default backup location first (if it exists), | ||
| // followed by the rest of the locations in no particular order. | ||
| func backupSyncSourceOrderFunc(objList client.ObjectList) client.ObjectList { |
There was a problem hiding this comment.
The input objList should can be converted to *velerov1api.BackupStorageLocationList{} directly, so that we can iterator its items and find the default BSL, and replace the default BSL element with items[0]?
blackpiglet
force-pushed
the
backup_sync_refact
branch
2 times, most recently
from
4595d67 to
8fb86fa
Compare
ywk253100
reviewed
Aug 29, 2022
|
|
||
| for i := range inputBSLList.Items { | ||
| location := inputBSLList.Items[i] | ||
| if location.Name == defaultBackupLocationName { |
There was a problem hiding this comment.
Seems that if there is no default BSL, the returning list is empty
ywk253100
reviewed
Aug 29, 2022
| } | ||
| } | ||
|
|
||
| for i := range inputBSLList.Items { |
There was a problem hiding this comment.
The two for loops in line 389 and 396 can be merged
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
blackpiglet
force-pushed
the
backup_sync_refact
branch
from
8fb86fa to
66ce740
Compare
ywk253100
previously approved these changes
Aug 30, 2022
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
blackpiglet
force-pushed
the
backup_sync_refact
branch
from
d72e9e9 to
08f1a15
Compare
Codecov Report
@@ Coverage Diff @@
## main #5218 +/- ##
==========================================
- Coverage 40.87% 40.69% -0.19%
==========================================
Files 233 233
Lines 20043 20093 +50
==========================================
- Hits 8193 8177 -16
- Misses 11253 11319 +66
Partials 597 597
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ywk253100
previously approved these changes
Aug 30, 2022
Lyndon-Li
approved these changes
Aug 30, 2022
ywk253100
approved these changes
Aug 30, 2022
wenterjoy
pushed a commit
to wenterjoy/velero
that referenced
this pull request
Dec 21, 2022
Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Clean backups after each test and fix exlude label test issue 1. Clean backups after each test to avoid exceeding limitation of storage capability during E2E test; 2. Fix exlude label test issue that namespace should not be included and excluded at the same time no matter by which way to config. Signed-off-by: danfengl <danfengl@vmware.com> Remove reference to non-existent doc fixes vmware-tanzu#4923 Signed-off-by: Daniel Jiang <jiangd@vmware.com> Uploader Implementation: Kopia backup and restore Signed-off-by: Ming <mqiu@vmware.com> update upstream codes Signed-off-by: Ming <mqiu@vmware.com> refactor gc controller with kubebuilder Signed-off-by: allenxu404 <qix2@vmware.com> add OADP to adopters list Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> fix typo Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> check vsc null pointer Signed-off-by: 李龙峰 <lilongfeng@inspur.com> kopia lib Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Move the code in pkg/restic/common.go to the proper package Move the code in pkg/restic/common.go to the proper package Fixes vmware-tanzu#5243 Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com> Don't panic when storageClassName is not set in stateful sets Signed-off-by: divolgin <dmitriy@replicated.com> Controller refactor code modifications. 1. Add some refactored controllers initiation code into enabledRuntimeControllers. 2. Add reconciler struct initiation function for DownloadRequest and ServerStatusRequest controllers. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> equip gc controller with configurable frequency Signed-off-by: allenxu404 <qix2@vmware.com> Update the website of velero to refelct the change of PM (vmware-tanzu#5260) Signed-off-by: Daniel Jiang <jiangd@vmware.com> Signed-off-by: Daniel Jiang <jiangd@vmware.com> Migrate backup sync controller from code-generator to kubebuilder (vmware-tanzu#5218) * Migrate backup sync controller from code-generator to kubebuilder 1. use kubebuilder's reconcile logic to replace controller's old logic. 2. use ginkgo and gomega to replace testing. 3. modify BSL reconciler registration method. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> * Add Option for PeriodicalEnqueueSource. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Co-authored-by: Xun Jiang <blackpiglet@gmail.com> Refactor BackupItemAction to backupitemaction/v1 Signed-off-by: Hoang, Phuong <phuong.n.hoang@dell.com> Add changelog Signed-off-by: Hoang, Phuong <phuong.n.hoang@dell.com> Add missing file Signed-off-by: Hoang, Phuong <phuong.n.hoang@dell.com> renamed update files so that protoc is run before CRD update. If generating protoc go files from scratch, `make update` fails if CRD generation happens first, since the protoc-generated files are imported by the api go files. protoc generation needs to happen earlier. Signed-off-by: Scott Seago <sseago@redhat.com> updated to newer protoc/protoc-gen-go Signed-off-by: Scott Seago <sseago@redhat.com> Updated plugin/framework server files to cope with protoc changes Signed-off-by: Scott Seago <sseago@redhat.com> some additional debug logs Signed-off-by: Scott Seago <sseago@redhat.com> fix edge cases for already exists resources Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog file Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> update changelog filename Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> change log level and error type Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> Uploader Implementation: Restic backup and restore Signed-off-by: Ming <mqiu@vmware.com> merge upstream code Signed-off-by: Ming <mqiu@vmware.com> Add enable API group on k8s resources E2E test upon issue vmware-tanzu#5146 Signed-off-by: danfengl <danfengl@vmware.com> Check for empty ns list before checking nslist[0] In determining whether a backup includes all namespaces, item_collector checks for an empty string in the first element of the ns list. If processing includes+excludes results in an empty list, treat this as another case of a not-all-namespaces backup rather than crashing velero. Signed-off-by: Scott Seago <sseago@redhat.com> Kopia Pod Volume Backup/Restore (vmware-tanzu#5259) * kopia pvbr Signed-off-by: Lyndon-Li <lyonghui@vmware.com> chore: remove duplicate word in comments Signed-off-by: Abirdcfly <fp544037857@gmail.com> add CSISnapshotTimeout for describe backup Signed-off-by: cleverhu <shouping.hu@daocloud.io> kopia pvbr smoking test changes Signed-off-by: Lyndon-Li <lyonghui@vmware.com> trim isAlreadyExistsError for restore Signed-off-by: cleverhu <shouping.hu@daocloud.io> refactor repo ensurer Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Add credentials to volume snapshot locations. This is analogous to the BSL creds work that was done previously, but for VSLs instead. Signed-off-by: Scott Seago <sseago@redhat.com> fix issue 4874 Signed-off-by: Lyndon-Li <lyonghui@vmware.com> issue fix 4874 update Signed-off-by: Lyndon-Li <lyonghui@vmware.com> add shorthand for labels columns Signed-off-by: cleverhu <shouping.hu@daocloud.io> Fix PVB finds wrong parent snapshot Signed-off-by: Ming <mqiu@vmware.com> Fix restore cmd extraflag overwrite bug Signed-off-by: Ming <mqiu@vmware.com> Don't move velero v1 plugins to new proto dir To preserve backwards compatibility, don't move velero v1 plugins to new proto dir. Signed-off-by: Scott Seago <sseago@redhat.com> Change the status of restore to completed from partially failed when restore empty backup Signed-off-by: allenxu404 <qix2@vmware.com> plugin/clientmgmt refactoring for BackupItemAction v1 Refactors the clientmgmt package to implement the plugin versioning changes needed for BIA v1 and overall package refactoring to support plugin versions in different packages. This should be all that's needed to move on to v2 for BackupItemAction. The remaining plugin types still need similar refactoring to what's being done here for BIA before attempting a v2 implementation. Signed-off-by: Scott Seago <sseago@redhat.com> plugin/framework refactoring for BackupItemAction v1 Refactors the framework package to implement the plugin versioning changes needed for BIA v1 and overall package refactoring to support plugin versions in different packages. This should be all that's needed to move on to v2 for BackupItemAction. The remaining plugin types still need similar refactoring to what's being done here for BIA before attempting a v2 implementation. Signed-off-by: Scott Seago <sseago@redhat.com> Remove github.com/apex/log logger. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> cancel downloadRequest checkFunc if timeout passed Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> fix issue 5352 Signed-off-by: Lyndon-Li <lyonghui@vmware.com> fix issue 5358 Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Clarify the help message for the default value of parameter --snapshot-volumes, when it's not set. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Support pause/unpause schedules Support pause/unpause schedule Fixes vmware-tanzu#2363 Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com> RestoreItemAction v1 refactoring for plugin api versioning Signed-off-by: Scott Seago <sseago@redhat.com> add useOwnerReferencesInBackup field doc Signed-off-by: cleverhu <shouping.hu@daocloud.io> Fix issue of fail to get command output for test verification When running velero backup/restore command, if the command result is "PartiallyFailed", it won't reture error as design, but we do need to know the debug information to figure out the reason, so the command output is needed to get the command result, then further action will be taken. Signed-off-by: danfengl <danfengl@vmware.com> rename pvbr param (vmware-tanzu#5370) Signed-off-by: Lyndon-Li <lyonghui@vmware.com> plugin versioning v1 refactor for VolumeSnapshotter Signed-off-by: Scott Seago <sseago@redhat.com> Remove snapshot related lister, informer and client from backup controller. (vmware-tanzu#5299) Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Add schedule backup timing E2E test Signed-off-by: danfengl <danfengl@vmware.com> fix issue 5386 Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Added backupController's UT to test the prepareBackupRequest() method BackupStorageLocation processing logic Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io> add change log Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io> Add Kopia support for Velero installation in E2E test Signed-off-by: danfengl <danfengl@vmware.com> Add backup opt-in/opt-out E2E test Signed-off-by: danfengl <danfengl@vmware.com> Fix Test_prepareBackupRequest_BackupStorageLocation UT failure. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Fix restore error with flag namespace-mappings (vmware-tanzu#5377) Signed-off-by: Ming <mqiu@vmware.com> A little note about TTL expiration I think is necessary this little comment about TTL expiration, because it can be confusing when the expiration time has passed and the data allocated and the snapshots are not erased at that time. Signed-off-by: Aaron Arias <33655005+aaronariasperez@users.noreply.github.com> Add backup status checking schedule controller. (vmware-tanzu#5283) Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com> Co-authored-by: Xun Jiang <blackpiglet@gmail.com> Exclude "csinodes.storage.k8s.io" and "volumeattachments.storage.k8s.io" from backup and restore by default. (vmware-tanzu#5064) Signed-off-by: Xun Jiang <jxun@vmware.com> Signed-off-by: Xun Jiang <jxun@vmware.com> Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com> Fix issues of E2E test for API group, migration and pv opt-out backup 1. One of API group test failed due to other PR with fix for treat PartiallyFailed as failure to collect debugbundle without wrap the origin error; 2. Fix migration test issue of wrong velero cli for backup commmand; 3. Fix wrong pararmeter name issue for pv opt-out backup test. Signed-off-by: danfengl <danfengl@vmware.com> update velero using klog to version v2.9.0 (vmware-tanzu#5396) Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Co-authored-by: Xun Jiang <blackpiglet@gmail.com> Change B/R describe cli to support kopia Signed-off-by: allenxu404 <qix2@vmware.com> Update Maintainers with the new PM pradeepkchaturvedi Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Maintainers with the new PM pradeepkchaturvedi Signed-off-by: OrlinVasilev <ovasilev@vmware.com> rename daemonset (vmware-tanzu#5390) Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Skip the exclusion check for additional resources returned by BIA This commit provides a simple contract that if the BackupItemAction plugin sets an annotation in a resource it has handled, the additional items will considered "must include" i.e. each of them will skip the "include-exclude" filter, such that the plugin developer can make sure they are included in the backup disregarding the filter setting in the bakcup CR. Signed-off-by: Daniel Jiang <jiangd@vmware.com> moved RIA execute input/output structs back to velero package The RIA refactoring moved velero.RestoreItemAction into a separate (restoreitemaction) v1 package. Unfortunately, this change would require plugins to make code changes to locate the RestoreItemActionExecuteInput and RestoreItemActionExecuteOutput structs. This commit restores those structs to the original velero package, leaving just the RestoreItemAction interface in the new v1 package. Signed-off-by: Scott Seago <sseago@redhat.com> fix-ctx-issue 1. Fix issue of kubectl client and server mismatch version in GitAction E2E job, refer to elastic/cloud-on-k8s#4737; 2. Adapt to the changing of keyword for involing Kpoia as fs backupper, new installtion breaked upgrade and migration tests; 3. Accept multi-labels of Ginkgo focus as input of E2E make command; 4. Distinguish workload namespace from each tests; 5. Fix issues of not using Velero util to perform Velero commands; 6. Add snapshot test case for NamespaceMapping E2E test; 7. Collect debug bundle after catching error of Velero backup or restore command; Signed-off-by: danfengl <danfengl@vmware.com> Pod Volume Backup/Restore Refactor: Rename Init Helper (vmware-tanzu#5432) * restore helper refactor Signed-off-by: Lyndon-Li <lyonghui@vmware.com> * resolve codespell Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: Lyndon-Li <lyonghui@vmware.com> remove restic from code Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Change subcommand restic to repo Signed-off-by: allenxu404 <qix2@vmware.com> Bump Go to 1.18 Signed-off-by: Gábor Lipták <gliptak@gmail.com> upgrade velero docker image Signed-off-by: Lyndon-Li <lyonghui@vmware.com> fix lint errors Signed-off-by: Lyndon-Li <lyonghui@vmware.com> fix lint loop iterator problem Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Add CSI VolumeSnapshot client back. (vmware-tanzu#5449) Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Add nil check before execution of csi snapshot delete Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> change CSISnapshotTimeout from point to normal var Signed-off-by: cleverhu <shouping.hu@daocloud.io> Fix CVE-2022-27191 https://nvd.nist.gov/vuln/detail/CVE-2022-27191 updates to: * golang.org/x/crypto v0.0.0-20220315160706-3147a52a75dd adds: * golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2 Signed-off-by: Wesley Hayutin <weshayutin@gmail.com> Resolve gopkg.in/yaml.v3 vulnerabilities as shown from https://security.snyk.io/package/golang/gopkg.in%2Fyaml.v3 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> increase ensure restic repository timeout (vmware-tanzu#5335) Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> Fix label naming issue for restore helper (vmware-tanzu#5469) Signed-off-by: danfengl <danfengl@vmware.com> Add more nil pointer check for CSI related code in backup controller. (vmware-tanzu#5388) Add some corner cases checking for CSI snapshot in backup controller. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> update k8s.io dependencies to 0.24.0 * This also required an update to use github.com/bombsimon/logrusr/v3 * 'WithClusterName' removed as per the k8s doc reasoning: * https://github.com/kubernetes/apimachinery/blob/release-1.24/pkg/apis/meta/v1/types.go\#L257-L259 * ('ClusterName was a legacy field that was always cleared by the system and never used') * Test was updated accordingly Signed-off-by: Kira Boyle <kira@replicated.com> Change name of changelog file Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com> Trivial correction to 1.7 upgrade instructions The container name for the aws plugin is `velero-plugin-for-aws`. There was an extra `velero-` prefix in the doc. Signed-off-by: Dave Pedu <dave@davepedu.com> Remove redundancy code block left by vmware-tanzu#5388. (vmware-tanzu#5483) Signed-off-by: Xun Jiang <blackpiglet@gmail.com> refactor pvbr doc Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Add credential file store in the backup deletion controller. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> fix backup failure with self-signed certification Signed-off-by: Ming <mqiu@vmware.com> remove restic in docs (vmware-tanzu#5499) Signed-off-by: Lyndon-Li <lyonghui@vmware.com> repo config for s3 compatible store Signed-off-by: Lyndon-Li <lyonghui@vmware.com> issue fix 5505 Signed-off-by: Lyndon-Li <lyonghui@vmware.com> fix restic backup progress error Signed-off-by: Ming <mqiu@vmware.com> Fix GCP StorageClass used for E2E testing's YAML syntax error. (vmware-tanzu#5536) Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Co-authored-by: Xun Jiang <blackpiglet@gmail.com> Enhance the restore priorities list to support specifying the low prioritized resources that need to be restored in the last Enhance the restore priorities list to support specifying the low prioritized resources that need to be r estored in the last Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> feat: dependabot workflow automation for updating dependency Signed-off-by: Pratik Raj <Rajpratik71@gmail.com> Fix pointer deference to string in error message Signed-off-by: Faizan Ahmad <faizan@obmondo.com> add VSL credentials documentation. Signed-off-by: Scott Seago <sseago@redhat.com> Add v1.10 velero upgrade doc Signed-off-by: Ming <mqiu@vmware.com> fix main TOC for 1.10 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> add note for left over resources Signed-off-by: Ming <mqiu@vmware.com> Modify dependabot rules by only fix security issues Signed-off-by: Ming <mqiu@vmware.com> remove gofrs uuid Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Upload Velero build package saved from build image to Google cloud storage Signed-off-by: danfengl <danfengl@vmware.com> Fix controller problematic log output Signed-off-by: Ming <mqiu@vmware.com> Add compile restic binary for CVE fix Signed-off-by: Ming <mqiu@vmware.com> Rename secret for Google cloud storage Signed-off-by: danfengl <danfengl@vmware.com> Fix restic cross platform compile Signed-off-by: Ming <mqiu@vmware.com> debug opt in out Signed-off-by: danfengl <danfengl@vmware.com> Update upgrade test for 1.10 Signed-off-by: danfengl <danfengl@vmware.com> Save vvelero image tarball only for velero namespace in docker registry (vmware-tanzu#5581) Signed-off-by: danfengl <danfengl@vmware.com> 1.10 changelog and doc (vmware-tanzu#5583) Signed-off-by: Lyndon-Li <lyonghui@vmware.com> update 1.10 readme Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Add Velero behind proxy document. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Add Velero File System Backup Performance Guide Signed-off-by: Ming <mqiu@vmware.com> update 1.10 release notes Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Update the Valero channel hash-name for Kubernetes Slack. Signed-off-by: Nikhil Maheshwari <nikhil.m2498@gmail.com> [Main Cherry-Pick]Enhance upgrade velero bash script Signed-off-by: Ming <mqiu@vmware.com> Add pause/unpause schedule e2e test (vmware-tanzu#5609) Signed-off-by: danfengl <danfengl@vmware.com> Restore ClusterBootstrap before Cluster Restore ClusterBootstrap before Cluster otherwise a new default ClusterBootstrap object is create for the cluster Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com> remove versions from kind matrix Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Bump goreleaser to v1.12.3 Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com> Fix git action issue for setup-gcloud Signed-off-by: danfengl <danfengl@vmware.com> Add verification for CRD installation Signed-off-by: danfengl <danfengl@vmware.com> Update the api-types doc This commit makes update to the update api-types docs to add missing fields. It also includes misc changes to the inline comment, and a change to Dockerfile to make sure the build-image works on mac Signed-off-by: Daniel Jiang <jiangd@vmware.com> cut v1.10 docs on main Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Add sleep before backing up new born CRD Signed-off-by: danfengl <danfengl@vmware.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct plugin name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct plugin name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> try to fix link check error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> reversed the order of name and kind Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct plugin name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct plugin name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> try to fix link check error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> Fix CVEs scanned by trivy Signed-off-by: Ming <mqiu@vmware.com> Fix links to compatibility matrix Signed-off-by: Lukas Hass <lukas@slucky.de> Update Velero and k8s version compatibility matrix. Due to CSIDriver is checked for Restic volume mounting path, and CSIDriver is GA and moved to storage v1 group in k8s v1.18, so update Velero v1.8, v1.9 and v1.10 compatible k8s version to 1.18-latest. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Item action progress monitoring design This design combines the requirements for the previously-merged Upload Progress Monitoring design with the requirements for the (not submitted but discussed in meetings and slack) proposed asynchronous item action plugins into one integrated proposal. Signed-off-by: Scott Seago <sseago@redhat.com> BackupItemAction v2 design This includes necessary changes to support async item action monitoring. Signed-off-by: Scott Seago <sseago@redhat.com> reversethe order of name and kind Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> RestoreItemAction v2 design Signed-off-by: Scott Seago <sseago@redhat.com> VolumeSnapshotter v2 API design Signed-off-by: Scott Seago <sseago@redhat.com> Prevent nil panic on exec restore hooks (vmware-tanzu#5675) * Prevent nil panic on exec restore hooks Signed-off-by: Dylan Murray <dymurray@redhat.com> refactor pvbr doc Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Add credential file store in the backup deletion controller. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> fix backup failure with self-signed certification Signed-off-by: Ming <mqiu@vmware.com> remove restic in docs (vmware-tanzu#5499) Signed-off-by: Lyndon-Li <lyonghui@vmware.com> repo config for s3 compatible store Signed-off-by: Lyndon-Li <lyonghui@vmware.com> issue fix 5505 Signed-off-by: Lyndon-Li <lyonghui@vmware.com> fix restic backup progress error Signed-off-by: Ming <mqiu@vmware.com> Fix GCP StorageClass used for E2E testing's YAML syntax error. (vmware-tanzu#5536) Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Co-authored-by: Xun Jiang <blackpiglet@gmail.com> Enhance the restore priorities list to support specifying the low prioritized resources that need to be restored in the last Enhance the restore priorities list to support specifying the low prioritized resources that need to be r estored in the last Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> Update Community meetings times vmware-tanzu#5091 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> feat: dependabot workflow automation for updating dependency Signed-off-by: Pratik Raj <Rajpratik71@gmail.com> Fix pointer deference to string in error message Signed-off-by: Faizan Ahmad <faizan@obmondo.com> add VSL credentials documentation. Signed-off-by: Scott Seago <sseago@redhat.com> Add v1.10 velero upgrade doc Signed-off-by: Ming <mqiu@vmware.com> fix main TOC for 1.10 Signed-off-by: OrlinVasilev <ovasilev@vmware.com> add note for left over resources Signed-off-by: Ming <mqiu@vmware.com> Modify dependabot rules by only fix security issues Signed-off-by: Ming <mqiu@vmware.com> remove gofrs uuid Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Upload Velero build package saved from build image to Google cloud storage Signed-off-by: danfengl <danfengl@vmware.com> Fix controller problematic log output Signed-off-by: Ming <mqiu@vmware.com> Add compile restic binary for CVE fix Signed-off-by: Ming <mqiu@vmware.com> Rename secret for Google cloud storage Signed-off-by: danfengl <danfengl@vmware.com> Fix restic cross platform compile Signed-off-by: Ming <mqiu@vmware.com> debug opt in out Signed-off-by: danfengl <danfengl@vmware.com> Update upgrade test for 1.10 Signed-off-by: danfengl <danfengl@vmware.com> Save vvelero image tarball only for velero namespace in docker registry (vmware-tanzu#5581) Signed-off-by: danfengl <danfengl@vmware.com> 1.10 changelog and doc (vmware-tanzu#5583) Signed-off-by: Lyndon-Li <lyonghui@vmware.com> update 1.10 readme Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Add Velero behind proxy document. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Add Velero File System Backup Performance Guide Signed-off-by: Ming <mqiu@vmware.com> update 1.10 release notes Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Update the Valero channel hash-name for Kubernetes Slack. Signed-off-by: Nikhil Maheshwari <nikhil.m2498@gmail.com> [Main Cherry-Pick]Enhance upgrade velero bash script Signed-off-by: Ming <mqiu@vmware.com> Add pause/unpause schedule e2e test (vmware-tanzu#5609) Signed-off-by: danfengl <danfengl@vmware.com> Restore ClusterBootstrap before Cluster Restore ClusterBootstrap before Cluster otherwise a new default ClusterBootstrap object is create for the cluster Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com> remove versions from kind matrix Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Bump goreleaser to v1.12.3 Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com> Fix git action issue for setup-gcloud Signed-off-by: danfengl <danfengl@vmware.com> Add verification for CRD installation Signed-off-by: danfengl <danfengl@vmware.com> Update the api-types doc This commit makes update to the update api-types docs to add missing fields. It also includes misc changes to the inline comment, and a change to Dockerfile to make sure the build-image works on mac Signed-off-by: Daniel Jiang <jiangd@vmware.com> cut v1.10 docs on main Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Add sleep before backing up new born CRD Signed-off-by: danfengl <danfengl@vmware.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct plugin name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct plugin name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> try to fix link check error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> reversed the order of name and kind Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct plugin name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image repository by configmap Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct changelog name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> modified according review comments Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> change image replace rule to match all the cases Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> use single bit "," as the delimiter Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> removed section of juding DELIMITER_KEY Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> corrected code spell error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> remove "Job" from the conditional Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> correct plugin name Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> try to fix link check error Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> Fix CVEs scanned by trivy Signed-off-by: Ming <mqiu@vmware.com> Fix links to compatibility matrix Signed-off-by: Lukas Hass <lukas@slucky.de> Update Velero and k8s version compatibility matrix. Due to CSIDriver is checked for Restic volume mounting path, and CSIDriver is GA and moved to storage v1 group in k8s v1.18, so update Velero v1.8, v1.9 and v1.10 compatible k8s version to 1.18-latest. Signed-off-by: Xun Jiang <blackpiglet@gmail.com> Item action progress monitoring design This design combines the requirements for the previously-merged Upload Progress Monitoring design with the requirements for the (not submitted but discussed in meetings and slack) proposed asynchronous item action plugins into one integrated proposal. Signed-off-by: Scott Seago <sseago@redhat.com> BackupItemAction v2 design This includes necessary changes to support async item action monitoring. Signed-off-by: Scott Seago <sseago@redhat.com> reversethe order of name and kind Signed-off-by: wenterjoy <zhaoxin26@lenovo.com> RestoreItemAction v2 design Signed-off-by: Scott Seago <sseago@redhat.com> VolumeSnapshotter v2 API design Signed-off-by: Scott Seago <sseago@redhat.com> Prevent nil panic on exec restore hooks (vmware-tanzu#5675) * Prevent nil panic on exec restore hooks Signed-off-by: Dylan Murray <dymurray@redhat.com> [Cherry-Pick]Fix error with Restic backup empty volumes Signed-off-by: Ming <mqiu@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Jiang blackpiglet@gmail.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #5022
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.