-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
equip gc controller with configurable frequency #5248
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5248 +/- ##
==========================================
- Coverage 41.03% 40.87% -0.17%
==========================================
Files 231 233 +2
Lines 19645 20043 +398
==========================================
+ Hits 8062 8193 +131
- Misses 10993 11253 +260
- Partials 590 597 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@allenxu404 Could you remove this line or just log the needed information? This hits a bug of delve when debugging Velero on Mac as the |
Thanks for your information. Yes, I think I can just log the name of backup instead. |
Signed-off-by: allenxu404 <qix2@vmware.com>
Signed-off-by: allenxu404 qix2@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.