Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equip gc controller with configurable frequency #5248

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

allenxu404
Copy link
Contributor

Signed-off-by: allenxu404 qix2@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

  • add a field of frequency into gcReconciler

Does your change fix a particular issue?

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #5248 (a8ba487) into main (e849441) will decrease coverage by 0.16%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##             main    #5248      +/-   ##
==========================================
- Coverage   41.03%   40.87%   -0.17%     
==========================================
  Files         231      233       +2     
  Lines       19645    20043     +398     
==========================================
+ Hits         8062     8193     +131     
- Misses      10993    11253     +260     
- Partials      590      597       +7     
Impacted Files Coverage Δ
pkg/cmd/server/server.go 6.60% <0.00%> (-0.04%) ⬇️
pkg/controller/gc_controller.go 55.55% <66.66%> (-0.76%) ⬇️
pkg/restic/common.go 26.86% <0.00%> (-12.92%) ⬇️
pkg/uploader/provider/kopia.go 57.02% <0.00%> (-4.14%) ⬇️
pkg/controller/backup_controller.go 48.19% <0.00%> (-0.29%) ⬇️
pkg/podvolume/util.go 100.00% <0.00%> (ø)
pkg/repository/manager.go 20.40% <0.00%> (ø)
pkg/repository/provider/restic.go 0.00% <0.00%> (ø)
pkg/restore/restic_restore_action.go 75.24% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

reasonerjt
reasonerjt previously approved these changes Aug 26, 2022
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blackpiglet blackpiglet self-requested a review August 29, 2022 06:44
@ywk253100
Copy link
Contributor

@allenxu404 Could you remove this line or just log the needed information? This hits a bug of delve when debugging Velero on Mac as the DeletionTimestamp of the backup is nil.

@allenxu404
Copy link
Contributor Author

@allenxu404 Could you remove this line or just log the needed information? This hits a bug of delve when debugging Velero on Mac as the DeletionTimestamp of the backup is nil.

Thanks for your information. Yes, I think I can just log the name of backup instead.

Signed-off-by: allenxu404 <qix2@vmware.com>
@blackpiglet blackpiglet merged commit 4bc3a3a into vmware-tanzu:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants