Refoctor backup controller based on kubebuilder #5835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuming-best
force-pushed
the
remove-client-go
branch
from
56d238c to
bef44b4
Compare
qiuming-best
force-pushed
the
remove-client-go
branch
2 times, most recently
from
bc71190 to
8a65c40
Compare
qiuming-best
removed request for
reasonerjt,
ywk253100,
blackpiglet and
Lyndon-Li
qiuming-best
force-pushed
the
remove-client-go
branch
from
1e5c66b to
c099811
Compare
qiuming-best
force-pushed
the
remove-client-go
branch
from
c099811 to
1c0e926
Compare
qiuming-best
changed the title
qiuming-best
force-pushed
the
remove-client-go
branch
2 times, most recently
from
b09aa22 to
727b8b3
Compare
qiuming-best
force-pushed
the
remove-client-go
branch
from
727b8b3 to
7f5e98c
Compare
ywk253100
previously approved these changes
Feb 17, 2023
qiuming-best
force-pushed
the
remove-client-go
branch
from
742632d to
27bbbec
Compare
Codecov Report
@@ Coverage Diff @@
## main #5835 +/- ##
==========================================
+ Coverage 39.94% 40.12% +0.17%
==========================================
Files 253 253
Lines 22259 22239 -20
==========================================
+ Hits 8892 8923 +31
+ Misses 12716 12665 -51
Partials 651 651
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qiuming-best
commented
Feb 28, 2023
| // By far, PodVolumeBackup, PodVolumeRestore, BackupStorageLocation controllers | ||
| // are not included in --disable-controllers list. | ||
| // This is because of PVB and PVR are used by node agent DaemonSet, | ||
| // and BSL controller is mandatory for Velero to work. | ||
| enabledControllers := map[string]func() controllerRunInfo{ |
There was a problem hiding this comment.
enabledControllers now are been removed
| for _, newController := range enabledControllers { | ||
| controllers = append(controllers, newController()) | ||
| } | ||
|
|
There was a problem hiding this comment.
not need anymore
| // Adding the controllers to the manager will register them as a (runtime-controller) runnable, | ||
| // so the manager will ensure the cache is started and ready before all controller are started | ||
| s.mgr.Add(managercontroller.Runnable(controllerRunInfo.controller, controllerRunInfo.numWorkers)) | ||
| } |
There was a problem hiding this comment.
not need anymore
blackpiglet
force-pushed
the
remove-client-go
branch
4 times, most recently
from
7112c06 to
02fa8c3
Compare
|
This is the basic E2E test cases result. Only node-port case failed. Checked with Danfeng. Some cloud providers have the same error. This is not the Velero function defect. https://gist.github.com/blackpiglet/2a2176ec5913b1bdf1937cdda421ab75 |
Signed-off-by: Ming <mqiu@vmware.com>
Signed-off-by: Ming <mqiu@vmware.com> Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
blackpiglet
force-pushed
the
remove-client-go
branch
from
02fa8c3 to
df8ab91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ming mqiu@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
#5026, Refoctor backup controller based on kubebuilder
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.