Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick release-1.12] Fix issue 6913 #7025

Merged

Conversation

shubham-pampattiwar
Copy link
Collaborator

Signed-off-by: Shubham Pampattiwar spampatt@redhat.com
(cherry picked from commit ee271b7)

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #7025 (36ad5da) into release-1.12 (7b76047) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@               Coverage Diff                @@
##           release-1.12    #7025      +/-   ##
================================================
- Coverage         60.48%   60.47%   -0.01%     
================================================
  Files               247      247              
  Lines             26401    26401              
================================================
- Hits              15968    15967       -1     
- Misses             9312     9313       +1     
  Partials           1121     1121              
Files Coverage Δ
pkg/controller/data_download_controller.go 75.27% <100.00%> (ø)
pkg/controller/data_upload_controller.go 68.28% <66.66%> (-0.17%) ⬇️

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add changelog file

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

keep canceling phase const

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

fix data download as well

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

address PR feedback

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

minor fixes

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
(cherry picked from commit ee271b7)

update changelog filename

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
Signed-off-by: lyndon <98304688+Lyndon-Li@users.noreply.github.com>
@Lyndon-Li Lyndon-Li merged commit dc525aa into vmware-tanzu:release-1.12 Oct 27, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants