Bring back 'make local'

[skriss]

Signed-off-by: Andy Goldstein andy.goldstein@gmail.com

I pulled this out of #495, creating a PR so we don't lose track of it.

I'd like to see the goarch detection move to only happen in make local, bc this is going to break make container when running on macOS.

[ncdc]

Thanks for splitting it out, and I agree

…

On Thu, Jul 26, 2018 at 9:15 PM Steve Kriss ***@***.***> wrote: Signed-off-by: Andy Goldstein ***@***.*** I pulled this out of #495 <#495>, creating a PR so we don't lose track of it. I'd like to see the goarch detection move to only happen in make local, bc this is going to break make container when running on macOS. ------------------------------ You can view, comment on, or merge this pull request online at: #711 Commit Summary - Bring back 'make local' File Changes - *M* Makefile <https://github.com/heptio/ark/pull/711/files#diff-0> (16) Patch Links: - https://github.com/heptio/ark/pull/711.patch - https://github.com/heptio/ark/pull/711.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#711>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABYhzlRLaFifjUlc9TmNjJmvxGk_K1ks5uKmmigaJpZM4VixJL> .

[nrb]

LGTM.

May want to update https://github.com/heptio/ark/blob/master/docs/build-from-scratch.md#cross-compiling to reference this target.

[skriss]

not ready to merge

[skriss]

@nrb which part are you saying should be updated in the cross-compiling section?

[skriss]

@ncdc PTAL if you get a chance, I think this addresses the comment re: only detecting local arch when running make local (just learned about target-specific variables)

[ncdc]

I think we can omit specifying all the variables that are unmodified and make should pass them through when executing build.sh. That would leave OUTPUT_DIR as the only one we need. Try that and see if it works?

[skriss]

nope :(

[ncdc]

Aha, we could export whatever variables we want to be passed down to all shell invocations from all targets, if desired.

[skriss]

Eh, maybe in a separate PR :)

[nrb]

@skriss I was thinking this text: By default, make builds an ark binary that runs on your host operating system and architecture.

My Makefile knowledge isn't great, but isn't the point of this PR that the default target all doesn't actually do that? local will do the detection, and all will build linux-amd64 all the time.

Am I getting that right?

[skriss]

Ah, I see what you mean. Yeah, that sentence isn't really true in the current state. Let me see if I can do some rewording there.

[skriss]

OK after re-reading that section + the Makefile, I made an edit to reflect existing reality better, but I'm not mentioning make local there because I think make build is the appropriate target to use.

[skriss]

@carlisia PTAL, merge if +1.

[carlisia]

👍