Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.12: Update Backup.Status.CSIVolumeSnapshotsCompleted during finalize #7111

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Nov 16, 2023

  • Add PatchResource unit test for backup status
  • refactor backup snapshot status updates into UpdateBackupSnapshotsStatus() and run in backup_finalizer_controller
  • skip this if SnapshotMoveData
  • remove waiting during finalize
  • CSIFeatureFlag enable check
  • update changelog to reflect removed waits
  • make update
  • revert test changes

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7047
Cherry-picks #7046

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai kaovilai force-pushed the backup-patch-status-unittest-release-1.12 branch from 355252c to 1a58ac2 Compare November 16, 2023 07:55
@kaovilai kaovilai changed the title backup patch status unittest release 1.12 release-1.12: backup patch status unittest Nov 16, 2023
@kaovilai kaovilai changed the title release-1.12: backup patch status unittest release-1.12: Update Backup.Status.CSIVolumeSnapshotsCompleted during finalize Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (c042d47) 60.61% compared to head (c8fd9d4) 60.54%.

Files Patch % Lines
pkg/backup/snapshots.go 0.00% 41 Missing ⚠️
pkg/cmd/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #7111      +/-   ##
================================================
- Coverage         60.61%   60.54%   -0.08%     
================================================
  Files               250      251       +1     
  Lines             26683    26688       +5     
================================================
- Hits              16175    16159      -16     
- Misses             9367     9392      +25     
+ Partials           1141     1137       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sseago
Copy link
Collaborator

sseago commented Nov 16, 2023

@kaovilai needs rebase

@kaovilai kaovilai force-pushed the backup-patch-status-unittest-release-1.12 branch from 1a58ac2 to 44b2ba6 Compare November 16, 2023 15:30
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
…tus() and run in backup_finalizer_controller

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@ywk253100 ywk253100 force-pushed the backup-patch-status-unittest-release-1.12 branch from 44b2ba6 to c8fd9d4 Compare November 17, 2023 02:45
@danfengliu danfengliu merged commit 7c05151 into vmware-tanzu:release-1.12 Nov 17, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants