-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-1.12: Update Backup.Status.CSIVolumeSnapshotsCompleted during finalize #7111
Merged
danfengliu
merged 8 commits into
vmware-tanzu:release-1.12
from
kaovilai:backup-patch-status-unittest-release-1.12
Nov 17, 2023
Merged
release-1.12: Update Backup.Status.CSIVolumeSnapshotsCompleted during finalize #7111
danfengliu
merged 8 commits into
vmware-tanzu:release-1.12
from
kaovilai:backup-patch-status-unittest-release-1.12
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
backup-patch-status-unittest-release-1.12
branch
from
November 16, 2023 07:55
355252c
to
1a58ac2
Compare
kaovilai
changed the title
backup patch status unittest release 1.12
release-1.12: backup patch status unittest
Nov 16, 2023
kaovilai
changed the title
release-1.12: backup patch status unittest
release-1.12: Update Backup.Status.CSIVolumeSnapshotsCompleted during finalize
Nov 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #7111 +/- ##
================================================
- Coverage 60.61% 60.54% -0.08%
================================================
Files 250 251 +1
Lines 26683 26688 +5
================================================
- Hits 16175 16159 -16
- Misses 9367 9392 +25
+ Partials 1141 1137 -4 ☔ View full report in Codecov by Sentry. |
sseago
approved these changes
Nov 16, 2023
@kaovilai needs rebase |
kaovilai
force-pushed
the
backup-patch-status-unittest-release-1.12
branch
from
November 16, 2023 15:30
1a58ac2
to
44b2ba6
Compare
ywk253100
approved these changes
Nov 17, 2023
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
…tus() and run in backup_finalizer_controller Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
https://github.com/vmware-tanzu/velero/pull/7046/files#r1380708644 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
ywk253100
force-pushed
the
backup-patch-status-unittest-release-1.12
branch
from
November 17, 2023 02:45
44b2ba6
to
c8fd9d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make update
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7047
Cherry-picks #7046
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.