Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSIVolumeSnapshotsCompleted in backup's status and the metric #7184

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Dec 6, 2023

Update CSIVolumeSnapshotsCompleted in backup's status and the metric during the backup finalize stage according to async operations content.

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7163

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8d8d68d) 61.83% compared to head (edb0860) 61.90%.
Report is 8 commits behind head on main.

Files Patch % Lines
pkg/backup/snapshots.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7184      +/-   ##
==========================================
+ Coverage   61.83%   61.90%   +0.07%     
==========================================
  Files         261      262       +1     
  Lines       28078    28175      +97     
==========================================
+ Hits        17362    17442      +80     
- Misses       9495     9499       +4     
- Partials     1221     1234      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet marked this pull request as ready for review December 6, 2023 15:42
@blackpiglet blackpiglet changed the title Fix issue #7163. Update CSIVolumeSnapshotsCompleted in backup's status and the metric Dec 6, 2023
@blackpiglet
Copy link
Contributor Author

@kaovilai
Could you help to review this PR?

Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, didnt know operations have resourceidentifier

Lyndon-Li
Lyndon-Li previously approved these changes Dec 7, 2023
Update CSIVolumeSnapshotsCompleted in backup's status and the metric
during backup finalize stage according to async operations content.

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet merged commit 759e8a9 into vmware-tanzu:main Dec 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csiVolumeSnapshotsAttempted/Completed not correctly populated in backup status
4 participants