Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8579 - set event burst #8590

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #8579, set event burst to block event broadcaster from filtering events

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.19%. Comparing base (be5f56a) to head (32ae409).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8590      +/-   ##
==========================================
+ Coverage   59.18%   59.19%   +0.01%     
==========================================
  Files         370      370              
  Lines       39622    39658      +36     
==========================================
+ Hits        23449    23477      +28     
- Misses      14689    14696       +7     
- Partials     1484     1485       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the fix-data-mover-progress-missing-after-25-updates branch from a256c0c to 06cf23a Compare January 8, 2025 07:40
@Lyndon-Li Lyndon-Li marked this pull request as ready for review January 8, 2025 07:56
kaovilai
kaovilai previously approved these changes Jan 9, 2025
@reasonerjt
Copy link
Contributor

@Lyndon-Li Thanks for the offline discussion, would you mind adding a few words in the commit message to clarify this approach is essentially by-passing the mechanism in k8s and we'll control the frequency of the events in velero's code?

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li force-pushed the fix-data-mover-progress-missing-after-25-updates branch from 06cf23a to 32ae409 Compare January 10, 2025 06:18
@Lyndon-Li
Copy link
Contributor Author

@Lyndon-Li Thanks for the offline discussion, would you mind adding a few words in the commit message to clarify this approach is essentially by-passing the mechanism in k8s and we'll control the frequency of the events in velero's code?

Done, added a comment in the code

@Lyndon-Li Lyndon-Li merged commit 46b8a31 into vmware-tanzu:main Jan 10, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants