🐛 Wait on vAppConfig during async create #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the behavior of the vAppConfig, LinuxPrep, and Sysprep bootstrap providers to wait on the VM to have a non-nil config.vAppConfig property when it is expected to exist. Async create means we are no longer falling through to the update logic directly after create, instead, relying on the reconciler to be reentrant. That all works fine, but the problem is vpxd is sending signal on the property collector that the VM is ready prior to its config.vAppConfig property being set. VM Op receives this signal and proceeds to reconcile the VM. Since previously we did not wait on an expected vAppConfig, we proceeded to configure and power on the VM. Once it is powered on, any customization that dependended upon the vAppConfig properties being set prior to first boot will no longer work. This patch returns an error from GetOVFVAppConfigForConfigSpec if the VM has a nil config.vAppConfig.
dilyar85
approved these changes
Dec 9, 2024
Minimum allowed line rate is |
bryanv
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch updates the behavior of the vAppConfig, LinuxPrep, and Sysprep bootstrap providers to wait on the VM to have a non-nil config.vAppConfig property when it is expected to exist.
Async create means we are no longer falling through to the update logic directly after create, instead, relying on the reconciler to be reentrant. That all works fine, but the problem is vpxd is sending signal on the property collector that the VM is ready prior to its config.vAppConfig property being set.
VM Op receives this signal and proceeds to reconcile the VM. Since previously we did not wait on an expected vAppConfig, we proceeded to configure and power on the VM. Once it is powered on, any customization that dependended upon the vAppConfig properties being set prior to first boot will no longer work.
This patch returns an error from GetOVFVAppConfigForConfigSpec if the VM has a nil config.vAppConfig.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
The following steps were taken to verify the fix:
Please add a release note if necessary: