Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added modules to retrieve policy group and security policy objects #428

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ParpingTam
Copy link

  • plugins/modules/nsxt_policy_group_info.py
  • plugins/modules/nsxt_policy_group_member_info.py
  • plugins/modules/nsxt_policy_group_member_types.py
  • plugins/modules/nsxt_policy_security_policy_facts.py
  • plugins/modules/nsxt_policy_security_policy_rule_stats.py
  • plugins/modules/nsxt_policy_security_policy_rules_facts.py

plugins/modules/common_utils.py modified.
Functions used for building query strings in URIs and for handling
retrieval of paged data were added.

The collection as it is now does not implement modules for the
retrieval of objects and focuses on CrUD ( no read ) functionality.
I want to work to flesh out the "R" functionality.

Signed-off-by: Ed McGuigan ed.mcguigan@palmbeachschools.org

@ParpingTam
Copy link
Author

I have been doing a lot of work with object data retrieved from NSX-T for objects relating to Distributed Firewall and it seems like a good idea to put them into the official ansible module.

	modified:   plugins/module_utils/common_utils.py
	new file:   plugins/modules/nsxt_policy_group_member_info.py
	new file:   plugins/modules/nsxt_policy_group_member_types.py
	new file:   plugins/modules/nsxt_policy_security_policy_facts.py
	new file:   plugins/modules/nsxt_policy_security_policy_rule_stats.py
	new file:   plugins/modules/nsxt_policy_security_policy_rules_facts.py
Added a number of modules relating to information about DFW policies and group
objects:
  plugins/modules/nsxt_policy_domain_deployment_maps_info.py
  plugins/modules/nsxt_policy_domain_info.py
  plugins/modules/nsxt_policy_group_associations_info.py

Modified the code in a number of modules to allow for local and global managers.
- plugins/modules/nsxt_policy_group_info.py
- plugins/modules/nsxt_policy_group_member_info.py
- plugins/modules/nsxt_policy_group_member_types.py
- plugins/modules/nsxt_policy_security_policy_facts.py
- plugins/modules/nsxt_policy_security_policy_rule_stats.py
- plugins/modules/nsxt_policy_security_policy_rules_facts.py

plugins/modules/common_utils.py modified.
Functions used for building query strings in URIs and for handling
retrieval of paged data were added.

The collection as it is now does not implement modules for the
retrieval of objects and focuses on CrUD ( no read ) functionality.
I want to work to flesh out the "R" functionality.

Signed-off-by: Ed McGuigan <ed.mcguigan@palmbeachschools.org>
@vmwclabot
Copy link
Member

@ParpingTam, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@edeka-spatt
Copy link

I am also using some of your new modules. I found some documentation is wrong eg: nsxt_policy_group_member_info.py states module: nsxt_policy_group_members (_info is missing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants