Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate delta stats of aggregated records #250

Open
zyiou opened this issue Aug 26, 2021 · 0 comments
Open

Inaccurate delta stats of aggregated records #250

zyiou opened this issue Aug 26, 2021 · 0 comments
Assignees
@heanlan

Comments

@zyiou
Copy link
Contributor

zyiou commented Aug 26, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently when aggregating records, we added delta stats https://github.com/vmware/go-ipfix/blob/main/pkg/intermediate/aggregate.go#L522-L528. Additionally, throughput calculation will make more sense when using accurate octetDeltaCount instead of source or destination specific delta stats.

Describe the solution you'd like
Assign maximum of the delta stats instead of summing up.

Describe alternatives you've considered
N/A

Additional context
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heanlan heanlan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve octetDeltaCount calculation heanlan/go-ipfix
2 participants
@zyiou @heanlan