Improve octetDeltaCount calculation #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heanlan
changed the title
heanlan
force-pushed
the
octet-delta-counts
branch
from
9e9e04b
to
eefc63f
Compare
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
+ Coverage 76.23% 76.26% +0.03%
==========================================
Files 17 17
Lines 2365 2368 +3
==========================================
+ Hits 1803 1806 +3
Misses 393 393
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
heanlan
force-pushed
the
octet-delta-counts
branch
16 times, most recently
from
6906339
to
c5b5011
Compare
heanlan
changed the title
srikartati
reviewed
Sep 2, 2021
heanlan
force-pushed
the
octet-delta-counts
branch
from
c5b5011
to
017c39e
Compare
zyiou
reviewed
Sep 3, 2021
zyiou
reviewed
Sep 3, 2021
Signed-off-by: heanlan <anlan9771@gmail.com>
heanlan
force-pushed
the
octet-delta-counts
branch
from
017c39e
to
f2e5883
Compare
zyiou
previously approved these changes
Sep 3, 2021
It works well in Antrea, referring to antrea-io/antrea#2692 |
heanlan
force-pushed
the
octet-delta-counts
branch
3 times, most recently
from
c1e9be9
to
dc9feef
Compare
heanlan
force-pushed
the
octet-delta-counts
branch
from
dc9feef
to
c732167
Compare
|
follow up in #270 , closing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we calculate
octetDeltaCountfor aggregated records, we are summing up the values from all incoming records. This approach leads to an issue that, in the case of inter-node flows, we will receive records from both source and destination node for the same flow, which makesoctetDeltaCountapproximate to 2*real value.To make it more accurate, we change the update logic to:
new_octetDeltaCount = max(new_octetDeltaCountFromSource, old_octetDeltaCount), if the incoming record is from source node;new_octetDeltaCount = max(new_octetDeltaCountFromDestination, old_octetDeltaCount), if the incoming record is from destination nodefixes: #250