Skip to content

Commit 334557f

Browse files
author
Miguel Sama
authored
Add AdminCatalog metadata methods (#430)
*Add method AdminCatalog.GetMetadata *Add method AdminCatalog.AddMetadata and AdminCatalog.AddMetadataAsync *Add method AdminCatalog.DeleteMetadata and AdminCatalog.DeleteMetadataAsync *Add test for admin catalog Test_MetadataOnCatalogCRUD *Add test for reading metadata from non-admin view *Add Metadata type constants *Add new methods, deprecated old ones and modified catalog methods signatures.   Add:     *vm.DeleteMetadataEntry     *vm.DeleteMetadataEntryAsync     *vm.AddMetadataEntry     *vm.AddMetadataEntryAsync     *vdc.DeleteMetadataEntry     *vdc.DeleteMetadataEntryAsync     *vdc.AddMetadataEntry     *vdc.AddMetadataEntryAsync     *vapp.DeleteMetadataEntry     *vapp.DeleteMetadataEntryAsync     *vapp.AddMetadataEntry     *vapp.AddMetadataEntryAsync     *vAppTemplate.AddMetadataEntry     *vAppTemplate.AddMetadataEntryAsync     *vAppTemplate.DeleteMetadataEntry     *vAppTemplate.DeleteMetadataEntryAsync     *mediaRecord.AddMetadataEntry     *mediaRecord.AddMetadataEntryAsync     *mediaRecord.DeleteMetadataEntry     *mediaRecord.DeleteMetadataEntryAsync     *media.AddMetadataEntry     *media.AddMetadataEntryAsync     *media.DeleteMetadataEntry     *media.DeleteMetadataEntryAsync   Deprecated:     *vm.DeleteMetadata     *vm.AddMetadata     *vdc.DeleteMetadata     *vdc.DeleteMetadataAsync     *vdc.AddMetadata     *vdc.AddMetadataAsync     *vapp.DeleteMetadata     *vapp.AddMetadata     *vAppTemplate.AddMetadata     *vAppTemplate.AddMetadataAsync     *vAppTemplate.DeleteMetadata     *vAppTemplate.DeleteMetadataAsync     *mediaRecord.AddMetadata     *mediaRecord.AddMetadataAsync     *mediaRecord.DeleteMetadata     *mediaRecord.DeleteMetadataAsync     *media.AddMetadata     *media.AddMetadataAsync     *media.DeleteMetadata     *media.DeleteMetadataAsync *Consolidate AddMetadataEntry and DeleteMetadataEntry Tests into CRUD ones for new Metadata Entry methods *Fix metadata tag bug Signed-off-by: Miguel Sama <msama@vmware.com>
1 parent be6421a commit 334557f

File tree

6 files changed

+825
-74
lines changed

6 files changed

+825
-74
lines changed

‎.changes/v2.15.0/430-deprecations.md

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
* Deprecated `vm.DeleteMetadata` in favor of `vm.DeleteMetadataEntry` [GH-430]
2+
* Deprecated `vm.AddMetadata` in favor of `vm.AddMetadataEntry` [GH-430]
3+
* Deprecated `vdc.DeleteMetadata` in favor of `vdc.DeleteMetadataEntry` [GH-430]
4+
* Deprecated `vdc.AddMetadata` in favor of `vdc.AddMetadataEntry` [GH-430]
5+
* Deprecated `vdc.AddMetadataAsync` in favor of `vdc.AddMetadataEntryAsync` [GH-430]
6+
* Deprecated `vdc.DeleteMetadataAsync` in favor of `vdc.DeleteMetadataEntryAsync` [GH-430]
7+
* Deprecated `vApp.DeleteMetadata` in favor of `vApp.DeleteMetadataEntry` [GH-430]
8+
* Deprecated `vApp.AddMetadata` in favor of `vApp.AddMetadataEntry` [GH-430]
9+
* Deprecated `vAppTemplate.AddMetadata` in favor of `vAppTemplate.AddMetadataEntry` [GH-430]
10+
* Deprecated `vAppTemplate.AddMetadataAsync` in favor of `vAppTemplate.AddMetadataEntryAsync` [GH-430]
11+
* Deprecated `vAppTemplate.DeleteMetadata` in favor of `vAppTemplate.DeleteMetadataEntry` [GH-430]
12+
* Deprecated `vAppTemplate.DeleteMetadataAsync` in favor of `vAppTemplate.DeleteMetadataEntryAsync` [GH-430]
13+
* Deprecated `mediaRecord.AddMetadata` in favor of `mediaRecord.AddMetadataEntry` [GH-430]
14+
* Deprecated `mediaRecord.AddMetadataAsync` in favor of `mediaRecord.AddMetadataEntryAsync` [GH-430]
15+
* Deprecated `mediaRecord.DeleteMetadata` in favor of `mediaRecord.DeleteMetadataEntry` [GH-430]
16+
* Deprecated `mediaRecord.DeleteMetadataAsync` in favor of `mediaRecord.DeleteMetadataEntryAsync` [GH-430]
17+
* Deprecated `media.AddMetadata` in favor of `media.AddMetadataEntry` [GH-430]
18+
* Deprecated `media.AddMetadataAsync` in favor of `media.AddMetadataEntryAsync` [GH-430]
19+
* Deprecated `media.DeleteMetadata` in favor of `media.DeleteMetadataEntry` [GH-430]
20+
* Deprecated `media.DeleteMetadataAsync` in favor of `media.DeleteMetadataEntryAsync` [GH-430]

‎.changes/v2.15.0/430-features.md

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
* Added types `types.MetadataStringValue`, `types.MetadataNumberValue`, `types.MetadataDateTimeValue` and `types.MetadataBooleanValue`
2+
for adding different kind of metadata to entities [GH-430]
3+
* Added support to set, get and delete metadata to AdminCatalog with the methods
4+
`AdminCatalog.AddMetadataEntry`, `AdminCatalog.AddMetadataEntryAsync`, `AdminCatalog.GetMetadata`,
5+
`AdminCatalog.DeleteMetadataEntry` and `AdminCatalog.DeleteMetadataEntryAsync`. [GH-430]
6+
* Added support to get metadata from Catalog with method `Catalog.GetMetadata` [GH-430]
7+
* Added to *VM* and *VApp* the methods `DeleteMetadataEntry`, `DeleteMetadataEntryAsync`, `AddMetadataEntry` and `AddMetadataEntryAsync`
8+
so it follows the same convention as the rest of entities that uses metadata. [GH-430]

‎govcd/api_vcd_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
//go:build api || openapi || functional || catalog || vapp || gateway || network || org || query || extnetwork || task || vm || vdc || system || disk || lb || lbAppRule || lbAppProfile || lbServerPool || lbServiceMonitor || lbVirtualServer || user || search || nsxv || nsxt || auth || affinity || role || alb || certificate || vdcGroup || ALL
2-
// +build api openapi functional catalog vapp gateway network org query extnetwork task vm vdc system disk lb lbAppRule lbAppProfile lbServerPool lbServiceMonitor lbVirtualServer user search nsxv nsxt auth affinity role alb certificate vdcGroup ALL
1+
//go:build api || openapi || functional || catalog || vapp || gateway || network || org || query || extnetwork || task || vm || vdc || system || disk || lb || lbAppRule || lbAppProfile || lbServerPool || lbServiceMonitor || lbVirtualServer || user || search || nsxv || nsxt || auth || affinity || role || alb || certificate || vdcGroup || metadata || ALL
2+
// +build api openapi functional catalog vapp gateway network org query extnetwork task vm vdc system disk lb lbAppRule lbAppProfile lbServerPool lbServiceMonitor lbVirtualServer user search nsxv nsxt auth affinity role alb certificate vdcGroup metadata ALL
33

44
/*
5-
* Copyright 2021 VMware, Inc. All rights reserved. Licensed under the Apache v2 License.
5+
* Copyright 2022 VMware, Inc. All rights reserved. Licensed under the Apache v2 License.
66
*/
77

88
package govcd

0 commit comments

Comments
 (0)