Add AdminCatalog metadata methods #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 26, 2022 15:51
Signed-off-by: Miguel Sama <msama@vmware.com>
*Add method AdminCatalog.GetMetadata *Add method AdminCatalog.AddMetadata and AdminCatalog.AddMetadataAsync *Add method AdminCatalog.DeleteMetadata and AdminCatalog.DeleteMetadataAsync Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
added 7 commits
January 28, 2022 11:39
Signed-off-by: Miguel Sama <msama@vmware.com>
* Add Test_ReadMetadataOnCatalog() Signed-off-by: Miguel Sama <msama@vmware.com>
…natures.
Add:
*vm.DeleteMetadataEntry
*vm.DeleteMetadataEntryAsync
*vm.AddMetadataEntry
*vm.AddMetadataEntryAsync
*vdc.DeleteMetadataEntry
*vdc.DeleteMetadataEntryAsync
*vdc.AddMetadataEntry
*vdc.AddMetadataEntryAsync
*vapp.DeleteMetadataEntry
*vapp.DeleteMetadataEntryAsync
*vapp.AddMetadataEntry
*vapp.AddMetadataEntryAsync
*vAppTemplate.AddMetadataEntry
*vAppTemplate.AddMetadataEntryAsync
*vAppTemplate.DeleteMetadataEntry
*vAppTemplate.DeleteMetadataEntryAsync
*mediaRecord.AddMetadataEntry
*mediaRecord.AddMetadataEntryAsync
*mediaRecord.DeleteMetadataEntry
*mediaRecord.DeleteMetadataEntryAsync
*media.AddMetadataEntry
*media.AddMetadataEntryAsync
*media.DeleteMetadataEntry
*media.DeleteMetadataEntryAsync
Deprecated:
*vm.DeleteMetadata
*vm.AddMetadata
*vdc.DeleteMetadata
*vdc.DeleteMetadataAsync
*vdc.AddMetadata
*vdc.AddMetadataAsync
*vapp.DeleteMetadata
*vapp.AddMetadata
*vAppTemplate.AddMetadata
*vAppTemplate.AddMetadataAsync
*vAppTemplate.DeleteMetadata
*vAppTemplate.DeleteMetadataAsync
*mediaRecord.AddMetadata
*mediaRecord.AddMetadataAsync
*mediaRecord.DeleteMetadata
*mediaRecord.DeleteMetadataAsync
*media.AddMetadata
*media.AddMetadataAsync
*media.DeleteMetadata
*media.DeleteMetadataAsync
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
requested review from
dataclouder,
Didainius,
lvirbalas and
vbauzys
as code owners
vbauzys
suggested changes
Feb 4, 2022
|
Thank you for effort making code more consistent ;-) |
Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
force-pushed
the
catalog-metadata
branch
from
501f66c to
02cb432
Compare
added 2 commits
February 7, 2022 17:09
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
vbauzys
reviewed
Feb 9, 2022
vbauzys
reviewed
Feb 9, 2022
Signed-off-by: Miguel Sama <msama@msama-a01.vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
adambarreiro
approved these changes
Feb 15, 2022
vbauzys
approved these changes
Feb 15, 2022
lvirbalas
requested changes
Feb 15, 2022
Signed-off-by: Miguel Sama <msama@vmware.com>
lvirbalas
approved these changes
Feb 22, 2022
Didainius
reviewed
Feb 22, 2022
Signed-off-by: Miguel Sama <msama@vmware.com>
Didainius
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: vmware/terraform-provider-vcd#372
Short description
Add catalog metadata methods to allow SDK users to add this kind of information to their catalogs
Detailed description
This PR adds four methods that will allow users from the SDK to add metadata to their catalogs. These methods are:
Users that want to add metadata to their catalogs need to have administrative permissions in their org, since only admins can add metadata to the catalogs.
This PR is also targeted to allow the VCD Terraform provider to add and update metadata when creating/updating catalogs.