Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ISOs with UDF filesystems to be uploaded with UploadMediaImage #474

Closed
rdavisunr opened this issue May 19, 2022 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@rdavisunr
Copy link

rdavisunr commented May 19, 2022

Is your feature request related to a problem? Please describe.

When attempting to upload an ISO with a UDF filesystem, I received an error that stated: file header didn't match ISO standard

Tracked this error down to the verifyIso function in media.go which subsequently calls verifyHeader, which only allows CD001 in the header (only allowing a ISO with an ISO 9660 filesystem).

Can ISOs with UDF filesystems also be supported?

Describe the solution you'd like

Modify verifyHeader to allow UDF in addition to ISO 9660.

Describe alternatives you've considered

For now, I reverted to creating ISOs in ISO 9660 with Joliet for support of longer filenames.

Additional context

No response

@rdavisunr rdavisunr added the enhancement New feature or request label May 19, 2022
@vbauzys
Copy link
Contributor

vbauzys commented May 25, 2022

Hi, @rdavisunr could share such a file for testing?

@rdavisunr
Copy link
Author

@vbauzysvmware - sure, ISO is in the attached zip.

For the sake of example, the ISO contains a couple of directories and a binary file (notepad++ installer).

udf-example.zip

@vbauzys
Copy link
Contributor

vbauzys commented May 26, 2022

@rdavisunr thank you :)

@vbauzys
Copy link
Contributor

vbauzys commented Jun 9, 2022

Hey @rdavisunr

If you want to try now, then you can build from master the provider.
Change will be released with 3.7.0 version :)

@vbauzys vbauzys closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants