Add udf support #479
Merged
Add udf support #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
# Conflicts: # govcd/api.go # govcd/api_vcd_test.go # govcd/openapi_endpoints.go # types/v56/constants.go # types/v56/openapi.go
vbauzys
requested review from
lvirbalas,
dataclouder,
Didainius,
mikeletux and
adambarreiro
as code owners
adambarreiro
approved these changes
May 26, 2022
mikeletux
approved these changes
May 26, 2022
Didainius
approved these changes
May 30, 2022
vbauzys
requested review from
lvirbalas,
mikeletux,
Didainius and
adambarreiro
and removed request for
dataclouder
lvirbalas
reviewed
Jun 2, 2022
| @@ -963,3 +963,31 @@ func (vcd *TestVCD) Test_CatalogQueryMediaList(check *C) { | |||
| // Check that media name is what it should be | |||
| check.Assert(medias[0].Name, Equals, vcd.config.Media.Media) | |||
| } | |||
|
|
|||
| // Tests System function UploadMediaImage by checking if provided UDF type standard iso file uploaded. | |||
There was a problem hiding this comment.
if provided UDF type standard iso file uploaded.
This part of the sentence doesn't make sense. Can you fix it on the way in some of your open PRs?
There was a problem hiding this comment.
UDF type of ISO file uploaded sounds better?
There was a problem hiding this comment.
Agreed changes are in https://github.com/vmware/go-vcloud-director/pull/478/files
There was a problem hiding this comment.
We agreed on:
// Tests System function UploadMediaImage by using provided ISO file of UDF type.
While in commit:
// Tests System function UploadMediaImage by checking if provided ISO file of UDF type.
There was a problem hiding this comment.
@mikeletux updated his PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #474