Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for v2.14.0 #423

Merged
merged 4 commits into from
Jan 7, 2022
Merged

Add changelog for v2.14.0 #423

merged 4 commits into from
Jan 7, 2022

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jan 6, 2022

Add changelog for v2.14.0

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review January 6, 2022 10:06
@Didainius Didainius removed the request for review from dataclouder January 6, 2022 10:06
CHANGELOG.md Outdated
* Added support for ALB Pool to NSX-T Edge Gateway via type `NsxtAlbPool` and functions `GetAllAlbPools`,
`GetAllAlbPoolSummaries`, `GetAlbPoolByName`, `GetAlbPoolById`, `CreateNsxtAlbPool`, `nsxtAlbPool.Update`,
`nsxtAlbPool.Delete` ([#414](https://github.com/vmware/go-vcloud-director/pull/414))
* Added support for ALB Virtual Services to NSX-T Edge Gateway via type `NsxtAlbVirtualService` and functions `GetAllAlbVirtualServices`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I see we lost consistency with "Added" vs. "Add" over time. The agreement was to use present form ("Add", "Fix", "Deprecate", etc.). Would be nice to get back to using present form in change logs.

Suggested change
* Added support for ALB Virtual Services to NSX-T Edge Gateway via type `NsxtAlbVirtualService` and functions `GetAllAlbVirtualServices`,
* Add support for ALB Virtual Services to NSX-T Edge Gateway via type `NsxtAlbVirtualService` and functions `GetAllAlbVirtualServices`,

CC: @vbauzysvmware @dataclouder

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you.

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 9d20e5d into vmware:master Jan 7, 2022
@Didainius Didainius deleted the changelog branch January 7, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants