Add user list to Group and add IsExternal behaviour to User

[adambarreiro]

Signed-off-by: abarreiro abarreiro@vmware.com

Description

This PR modifies some behaviour, described below, of the Group and User resources.

The proposed changes enhance this Group type by adding the UsersList attribute. This attribute contains a list of references to all the users that belong to the group. However, and this is a bit of a quirk, this list is only populated whenever the user is created after the group.
For reference, the behaviour is exactly the same as the attribute GroupReferences from the User type. It's also populated in the same scenario, only.

As a side change, this PR also changes how passwords are managed for Users when they're external, or in other words, when they're imported (using UI terms). When IsExternal is true, this means the user is imported. When it is imported, it doesn't need a password. If a password is specified anyway, it is ignored by VCD. For the sake of simplicity, in the changes proposed we simply remove it when this happens.

Also, when a user is imported, only the username+role is required (+other flags such as IsExternal=true). This matches the Import user UI. The remaining fields are filled by fetching the details from the LDAP.

List of changes

Added UsersList to the Group type

When you import a LDAP group in VCD, and there are some users that belong to this group, this list will be populated.

Added a new test for Groups

It imports a Group from the testing LDAP, imports a user from the testing LDAP, then checks that retrieving the group returns the imported user in the list.

Added IsExternal attribute to the OrgUserConfiguration struct

When a user is imported, and not created, IsExternal must be true. Otherwise, VCD considers it as a local user instead of imported from LDAP. This struct is just used as a simplification of the User XML.

Modified Password behaviour for users

Before, password was mandatory. This is not true for users being created with IsExternal=true, which ignore the password. I took the decision of overriding this field for simplicity, but VCD ignores it if populated anyway.

[lvirbalas]

Just a tiny ask.

[lvirbalas]

Where is the changelog entry?

[adambarreiro]

Where is the changelog entry?

I forgot to add it. I've just pushed it. Thanks for reminding!

[Didainius]

Looks great, thanks

[mikeletux]

Looks great @adambarreiro , approved!