Fix bug Test_VdcUpdateStorageProfile test #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainst a pointer Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
requested review from
lvirbalas,
dataclouder,
Didainius and
vbauzys
as code owners
adambarreiro
approved these changes
Mar 17, 2022
vbauzys
approved these changes
Mar 17, 2022
Didainius
approved these changes
Mar 17, 2022
lvirbalas
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No PR associated with this bug.
@adambarreiro and myself found this while running the test suite.
Description
There is a bug in
Test_VdcUpdateStorageProfilethat compares a type bool against a pointer. The test fails because of this.Detailed description
In test ´Test_VdcUpdateStorageProfile´, one of the checks is wrong as it tries to compare a
booltype against apointertype:We must deference the pointer, so it looks like: