Add generic CRUD metadata by href functions #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 2 commits
April 4, 2022 13:02
…ctor into add-metadata-by-href
adambarreiro
requested review from
lvirbalas,
dataclouder,
Didainius,
vbauzys and
mikeletux
as code owners
added 4 commits
April 4, 2022 15:10
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
reviewed
Apr 5, 2022
Signed-off-by: abarreiro <abarreiro@vmware.com>
vbauzys
approved these changes
Apr 5, 2022
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
approved these changes
Apr 5, 2022
added 2 commits
April 5, 2022 18:13
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into add-metadata-by-href Signed-off-by: abarreiro <abarreiro@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: abarreiro abarreiro@vmware.com
This PR relates to vmware/terraform-provider-vcd#372, as the goal is to provide CRUD functions for metadata to resources that don't have an associated type, like Storage profiles.
The functions just retrieve an HREF instead, and perform the metadata operation on it.
Another way of doing this would be changing the signature to:
But I followed the approach of having this method associated to
VCDClientinstead. (This is, of course, open to discussion).