Catalog and LDAP tests fix #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 4, 2022 10:23
…o VCD Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
…the Org catalog publishing bug Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
requested review from
lvirbalas,
dataclouder,
Didainius,
vbauzys and
adambarreiro
as code owners
|
Not sure if I should include changelog for this @lvirbalas @Didainius @vbauzysvmware @adambarreiro @datacharmer |
adambarreiro
approved these changes
Apr 4, 2022
Didainius
approved these changes
Apr 5, 2022
Yes, please. As this is purely testing, you can add to the IMPROVEMENTS section. LGTM, otherwise :) |
lvirbalas
approved these changes
Apr 5, 2022
vbauzys
approved these changes
Apr 5, 2022
Signed-off-by: Miguel Sama <msama@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not associated with any issue.
Description
Fix issues with Catalog tests, as well as LDAP test framework.
Detailed description
This PR addresses two issues that were impacting tests.
Issues solved related Catalog
There were some Catalog tests that were not removing the CatalogItems being upload to Catalogs. These tests were leveraging the function
AddToCleanupListto delete those CatalogItems. This was leading to issues because the clean-up function is executed at the end of the test framework, and other tests might not be aware about the changes being done there.The fix introduced here is to make every tests responsible of cleaning up whatever it has uploaded to Catalogs after the testing part has been done and right before the test returns. Hence, the
AddToCleanupListfunction lays as last resort for cleaning-up the environment at the end of the tests if something fails.Issues solved related LDAP
Turns out that when configuring LDAP settings, for whatever reason, two Org catalog publishing vars gets disable (these are
Publish external catalogsandSubscribe to external catalogs). This is a know issue and VCD team is addressing it to be solved. This interference with more tests as it makes the environment non-consistent.In the meantime, this workaround what it does is, before doing any configuration, it grabs those two values, and when all LDAP testing sub-framework is closing up, is sets those vars again to the Org and finishes.
Tested and working in VCD 10.2.2 and 10.3.2