Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security tags capabilities to govcd #467

Merged
merged 40 commits into from
May 10, 2022
Merged

Add security tags capabilities to govcd #467

merged 40 commits into from
May 10, 2022

Conversation

mikeletux
Copy link
Contributor

@mikeletux mikeletux commented Apr 26, 2022 •
edited
Loading

This PR does not have any issue associated.

Description

This PR brings the possibility of using Security Tags, which is a new feature of VCD 10.3.0+

Detailed description

With this PR, govcd users will be able to use new methods GetSecurityTaggedEntities, GetSecurityTagValues, GetVMSecurityTags to read information about security tags and UpdateSecurityTag and UpdateVMSecurityTags to modify them.

Also four new structs have been added: SecurityTag, SecurityTaggedEntity, SecurityTagValue and EntitySecurityTags.

Also a new test Test_SecurityTags have been added which checks all above mentioned methods.

@mikeletux mikeletux marked this pull request as ready for review April 26, 2022 14:34
@mikeletux mikeletux removed the request for review from dataclouder April 26, 2022 14:34
@mikeletux mikeletux self-assigned this Apr 26, 2022
vbauzys
vbauzys suggested changes Apr 26, 2022
View reviewed changes
@mikeletux mikeletux marked this pull request as draft April 29, 2022 10:26
Miguel Sama added 18 commits May 3, 2022 09:43
First implementation of GetSecurityTaggedEntities
9e3b787 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add skeleton for test Test_NsxtSecurityTags
ebb13b7 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add endpoint types.OpenApiEndpointSecurityTags
fc0acbe 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add openApi constant OpenApiEndpointSecurityTags
8d9ed2d 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add NsxtSecurityTag and SecurityTaggedEntity structs
53150d4 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add type SecurityTagValue
6fb5c0b 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add GetSecurityTagValues
75d2dc7 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add test Test_GetSecurityTagValues
fce8ceb 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add comment to newOrgUserConnection warning to use user name in lower…
30e43e7 
…case due to a bug

Signed-off-by: Miguel Sama <msama@vmware.com>
Add EntitySecurityTags
4a40bb8 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add GetVMSecurityTags
09c1401 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add test for Test_GetVMSecurityTags
28c4ea6 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add comment
dcdacd3 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add UpdateSecurityTag
eebce2c 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add Test_UpdateSecurityTag and Test_UpdateVMSecurityTags
05bcfca 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add Test_SecurityTags to consolidate tests
2142c0d 
Signed-off-by: Miguel Sama <msama@vmware.com>
Rename file
b8cc8a2 
Signed-off-by: Miguel Sama <msama@vmware.com>
Delete old files
cfd4ce0 
Signed-off-by: Miguel Sama <msama@vmware.com>
Miguel Sama added 4 commits May 3, 2022 09:43
Fix test
25e0990 
Signed-off-by: Miguel Sama <msama@vmware.com>
Improve test
f26eb9d 
Signed-off-by: Miguel Sama <msama@vmware.com>
Change method receivers
4745615 
Signed-off-by: Miguel Sama <msama@vmware.com>
Update tests
8f90aac 
Signed-off-by: Miguel Sama <msama@vmware.com>
@mikeletux mikeletux force-pushed the nsxt-security-tags branch from cb91fd9 to 8f90aac Compare May 3, 2022 07:44
Miguel Sama added 3 commits May 4, 2022 10:09
Move VM security tags methods under VM struct
1043eec 
Signed-off-by: Miguel Sama <msama@vmware.com>
Improved tests
48a2379 
Signed-off-by: Miguel Sama <msama@vmware.com>
Update changelog
66d6306 
Signed-off-by: Miguel Sama <msama@vmware.com>
@mikeletux mikeletux requested review from lvirbalas and vbauzys May 4, 2022 10:02
@mikeletux mikeletux marked this pull request as ready for review May 4, 2022 10:02
vbauzys
vbauzys reviewed May 5, 2022
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few simple things left.

Change order checks
5766a35 
Signed-off-by: Miguel Sama <msama@vmware.com>
adambarreiro
adambarreiro reviewed May 5, 2022
View reviewed changes
Didainius
Didainius reviewed May 5, 2022
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments for how to make it more aligned with the approach this SDK has and to make it feel more uniform for consumers,

lvirbalas
lvirbalas approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and +1 for @Didainius suggestions).

Miguel Sama added 6 commits May 5, 2022 15:37
Update changelog
79f489d 
Signed-off-by: Miguel Sama <msama@vmware.com>
Improve security tags code
4070c24 
Signed-off-by: Miguel Sama <msama@vmware.com>
Change test to be compatible with new methods
465d380 
Signed-off-by: Miguel Sama <msama@vmware.com>
Update changelog
e20bdcc 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add GetAllSecurityTaggedEntitiesByName
db18c03 
Signed-off-by: Miguel Sama <msama@vmware.com>
Add test for GetAllSecurityTaggedEntitiesByName
05a7619 
Signed-off-by: Miguel Sama <msama@vmware.com>
Didainius
Didainius approved these changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comment fixes.

Miguel Sama added 2 commits May 6, 2022 11:29
Small fixes
ccd9cfd 
Signed-off-by: Miguel Sama <msama@vmware.com>
Merge remote-tracking branch 'origin' into nsxt-security-tags
44b39a3 
Signed-off-by: Miguel Sama <msama@vmware.com>
@mikeletux mikeletux merged commit d905678 into vmware:main May 10, 2022
@mikeletux mikeletux deleted the nsxt-security-tags branch May 10, 2022 13:29
@mkriegs mkriegs mentioned this pull request Jun 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

@vbauzys vbauzys vbauzys approved these changes

Assignees

@mikeletux mikeletux

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikeletux @adambarreiro @lvirbalas @Didainius @vbauzys @vmwclabot