Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRUD metadata functions to CatalogItem #471

Merged
merged 3 commits into from
May 17, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented May 12, 2022

Description

This PR provides a set of CRUD functions for the CatalogItem struct. With these, a user of the SDK can retrieve, create and delete metadata for catalog items.

abarreiro added 2 commits May 12, 2022 09:31
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro changed the title Add catalog item metadata Add CRUD metadata functions to CatalogItem May 12, 2022
@adambarreiro adambarreiro self-assigned this May 12, 2022
@adambarreiro adambarreiro marked this pull request as ready for review May 12, 2022 08:21
@adambarreiro adambarreiro marked this pull request as draft May 12, 2022 08:48
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (without the filtering/search too).

@adambarreiro adambarreiro marked this pull request as ready for review May 12, 2022 12:46
@adambarreiro adambarreiro removed the request for review from dataclouder May 17, 2022 13:08
@adambarreiro adambarreiro merged commit e1ba152 into vmware:main May 17, 2022
@adambarreiro adambarreiro deleted the add-catalog-item-metadata branch May 17, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants